Page MenuHomeFreeBSD

net.inet.tcp.tolerate_missing_ts=1
ClosedPublic

Authored by tuexen on Jun 11 2021, 6:29 PM.
Tags
None
Referenced Files
F102140571: D30740.diff
Fri, Nov 8, 3:07 AM
Unknown Object (File)
Thu, Nov 7, 2:43 AM
Unknown Object (File)
Wed, Nov 6, 11:52 AM
Unknown Object (File)
Tue, Nov 5, 11:35 PM
Unknown Object (File)
Tue, Nov 5, 11:35 PM
Unknown Object (File)
Tue, Nov 5, 1:56 PM
Unknown Object (File)
Tue, Nov 5, 1:04 PM
Unknown Object (File)
Tue, Nov 5, 12:59 PM
Subscribers

Details

Summary

As of June 2021, several TCP stacks violate RFC 7323 from September 2014:

  • Omniswitch 63xx and 64xx models (negotiating TS, but not sending them).
  • HP LaserJet 500 color M551dn (negotiating TS, but not sending them).
  • IPFW TCP keep-alive injection (not sending TS when injecting packets).
  • Mac OS 11.4 (negotiating TS, but not sending TS on keep-alive packets).

Therefore tolerating violations for now...

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jun 11 2021, 6:32 PM
This revision now requires review to proceed.Jun 11 2021, 7:51 PM
rgrimes added inline comments.
share/man/man4/tcp.4
385–387

Perhaps make the same explination here as is in the comment of the code so that people wont turn this off without knowing what it is that is non compliant?

This revision is now accepted and ready to land.Jun 11 2021, 11:20 PM
share/man/man4/tcp.4
385–387

I was thinking about this. I wanted to provide some explicit informations about the current situation,
in case someone considers to change the default in the future. That is why I put the information in
the code, not just in the commit message.

However, I don't want to blame anybody. That is the reason why I did not put it in the more
prominent place in the man page. On the other hand, your arugerment is also reasonable.
I'll bring it up at the next transport call...

share/man/man4/tcp.4
385–387

How about a compromise?

As of June 2021, several implementations in common use are known to be non-compliant. Disabling this sysctl may impair the host's ability to communicate with these non-compliant implementations.

I wound not advise putting names in the man page.

This revision now requires review to proceed.Jun 19 2021, 10:17 AM
tuexen added inline comments.
share/man/man4/tcp.4
385–387

Used a similar text.

This revision is now accepted and ready to land.Jun 19 2021, 12:38 PM
This revision was automatically updated to reflect the committed changes.
tuexen marked an inline comment as done.