Differential D30740

net.inet.tcp.tolerate_missing_ts=1
ClosedPublic
Actions

Authored by tuexen on Jun 11 2021, 6:29 PM.

Tags

None

Referenced Files

	F102140571: D30740.diff
	Fri, Nov 8, 3:07 AM

	Unknown Object (File)
	Thu, Nov 7, 2:43 AM

	Unknown Object (File)
	Wed, Nov 6, 11:52 AM

	Unknown Object (File)
	Tue, Nov 5, 11:35 PM

	Unknown Object (File)
	Tue, Nov 5, 11:35 PM

	Unknown Object (File)
	Tue, Nov 5, 1:56 PM

	Unknown Object (File)
	Tue, Nov 5, 1:04 PM

	Unknown Object (File)
	Tue, Nov 5, 12:59 PM

Subscribers

Details

Reviewers

rgrimes
rrs
jtl
rscheff

Group Reviewers

Commits

rGb9dc12859790: tcp: tolerate missing timestamps
rGc5ba872129b3: tcp: tolerate missing timestamps
rG870af3f4dc57: tcp: tolerate missing timestamps

Summary

As of June 2021, several TCP stacks violate RFC 7323 from September 2014:

Omniswitch 63xx and 64xx models (negotiating TS, but not sending them).
HP LaserJet 500 color M551dn (negotiating TS, but not sending them).
IPFW TCP keep-alive injection (not sending TS when injecting packets).
Mac OS 11.4 (negotiating TS, but not sending TS on keep-alive packets).

Therefore tolerating violations for now...

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

tuexen created this revision.Jun 11 2021, 6:29 PM

Herald added a reviewer: transport. · View Herald TranscriptJun 11 2021, 6:29 PM

Herald added a subscriber: melifaro. · View Herald Transcript

tuexen requested review of this revision.Jun 11 2021, 6:29 PM

rscheff accepted this revision.Jun 11 2021, 6:32 PM

This revision is now accepted and ready to land.Jun 11 2021, 6:32 PM

Change man-page.

This revision now requires review to proceed.Jun 11 2021, 7:51 PM

rgrimes accepted this revision.Jun 11 2021, 11:20 PM

rgrimes added inline comments.

share/man/man4/tcp.4
385	Perhaps make the same explination here as is in the comment of the code so that people wont turn this off without knowing what it is that is non compliant?

This revision is now accepted and ready to land.Jun 11 2021, 11:20 PM

tuexen added inline comments.Jun 12 2021, 2:44 PM

share/man/man4/tcp.4
385	I was thinking about this. I wanted to provide some explicit informations about the current situation, in case someone considers to change the default in the future. That is why I put the information in the code, not just in the commit message. However, I don't want to blame anybody. That is the reason why I did not put it in the more prominent place in the man page. On the other hand, your arugerment is also reasonable. I'll bring it up at the next transport call...

jtl added inline comments.Jun 17 2021, 3:03 PM

share/man/man4/tcp.4
385	How about a compromise? As of June 2021, several implementations in common use are known to be non-compliant. Disabling this sysctl may impair the host's ability to communicate with these non-compliant implementations.

I wound not advise putting names in the man page.

tuexen updated this revision to Diff 91084.Jun 19 2021, 10:17 AM

This revision now requires review to proceed.Jun 19 2021, 10:17 AM

tuexen marked 2 inline comments as done.Jun 19 2021, 10:38 AM

tuexen added inline comments.

share/man/man4/tcp.4
385	Used a similar text.

rgrimes accepted this revision.Jun 19 2021, 12:38 PM

This revision is now accepted and ready to land.Jun 19 2021, 12:38 PM

Closed by commit rG870af3f4dc57: tcp: tolerate missing timestamps (authored by tuexen). · Explain WhyJun 27 2021, 2:06 PM

This revision was automatically updated to reflect the committed changes.

tuexen marked an inline comment as done.

tuexen added a commit: rG870af3f4dc57: tcp: tolerate missing timestamps.

tuexen added a commit: rGc5ba872129b3: tcp: tolerate missing timestamps.Jul 13 2021, 6:27 PM

tuexen added a commit: rGb9dc12859790: tcp: tolerate missing timestamps.Jul 14 2021, 7:44 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

6 lines

sys/

netinet/

9 lines

Diff 91084

share/man/man4/tcp.4

Loading...

sys/netinet/tcp_subr.c

Loading...