pf: store L4 headers in pf_pdesc
ClosedPublic
Actions

Authored by kp on Jun 10 2021, 6:14 PM.

Details

Reviewers

donner
scottl

Group Reviewers

pfsense
network

Commits

rG47535a9065ac: pf: store L4 headers in pf_pdesc
rGc816b23784a6: pf: store L4 headers in pf_pdesc
rGd38630f6192a: pf: store L4 headers in pf_pdesc

Summary

Rather than pointers to the headers store full copies. This brings us
slightly closer to what OpenBSD does, and also makes more sense than
storing pointers to stack variable copies of the headers.

MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39839
Build 36728: arc lint + arc unit

Event Timeline

kp created this revision.Jun 10 2021, 6:14 PM

Herald added subscribers: melifaro, farrokhi, ae, imp. · View Herald TranscriptJun 10 2021, 6:14 PM

kp requested review of this revision.Jun 10 2021, 6:14 PM

Harbormaster completed remote builds in B39835: Diff 90714.Jun 10 2021, 6:14 PM

kp added a reviewer: network.Jun 10 2021, 6:16 PM

donner added a subscriber: donner.Jun 10 2021, 8:00 PM

donner added inline comments.

sys/net/pfvar.h
931	Seems to be used as a pointer to a variable length data space. The common idiom is `char any[0]`. This also avoids to use `&complex_entry.any` instead of `complex_entry.any`.