net80211/LinuxKPI: add more radiotap definitions
ClosedPublic
Actions

Authored by bz on Jun 4 2021, 5:55 PM.

Details

Reviewers

• hselasky
adrian
sam

Group Reviewers

wireless

Commits

rGa30fe52a12f2: net80211/LinuxKPI: add more radiotap definitions
rGb5d37e5a20ab: net80211/LinuxKPI: add more radiotap definitions

Summary

Add more raditap defintions based on "names" found in actual drivers
and based on documentation from www.radiotap.org (where avail).

Leave one specific "duplicate" in the LinuxKPI implementation but
otherwise manae it all in net80211.

Sponsored by: The FreeBSD Foundation
MFC after: 10 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 39709
Build 36598: arc lint + arc unit

Event Timeline

bz created this revision.Jun 4 2021, 5:55 PM

Herald added subscribers: melifaro, emaste, imp. · View Herald TranscriptJun 4 2021, 5:55 PM

bz requested review of this revision.Jun 4 2021, 5:55 PM

Harbormaster completed remote builds in B39709: Diff 90425.Jun 4 2021, 5:55 PM

I am not sure where the already present "VHT" ones came from (tcpdump maybe?) but we don't seem to use them in any driver.
Is there any other out-of-tree work depending on them?

• hselasky accepted this revision.Jun 4 2021, 9:04 PM

This revision is now accepted and ready to land.Jun 4 2021, 9:04 PM

adrian accepted this revision.Jun 5 2021, 1:37 AM

I suspect following what's in wireshark is more important than radiotap.org.

In D30641#688505, @sam wrote:

I suspect following what's in wireshark is more important than radiotap.org.

Thanks for the link!

Closed by commit rGb5d37e5a20ab: net80211/LinuxKPI: add more radiotap definitions (authored by bz). · Explain WhyJun 5 2021, 4:36 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGb5d37e5a20ab: net80211/LinuxKPI: add more radiotap definitions.

bz added a commit: rGa30fe52a12f2: net80211/LinuxKPI: add more radiotap definitions.Jul 18 2021, 12:39 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

net/

ieee80211_radiotap.h

55 lines

net80211/

ieee80211_radiotap.h

134 lines

Diff 90425

View Options

sys/compat/linuxkpi/common/include/net/ieee80211_radiotap.h