Page MenuHomeFreeBSD
Differential D30611

ngatm: Handle errors from uni_msg_extend()
ClosedPublic
Actions

Authored by markj on Jun 2 2021, 1:55 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 18, 4:48 PM
Unknown Object (File)
Oct 15 2024, 6:44 PM
Unknown Object (File)
Oct 3 2024, 10:26 AM
Unknown Object (File)
Oct 3 2024, 1:13 AM
Unknown Object (File)
Sep 30 2024, 11:11 PM
Unknown Object (File)
Sep 30 2024, 3:32 AM
Unknown Object (File)
Sep 29 2024, 5:14 AM
Unknown Object (File)
Sep 27 2024, 5:18 PM
View All 52 Files
Subscribers
imp

Details

Reviewers
harti
Commits
rGe755e2776ddf: ngatm: Handle errors from uni_msg_extend()
Summary

uni_msg_extend() may fail due to a memory allocation failure. In this
case, though, the message is freed, so callers shouldn't touch it.

PR: 255861
MFC after: 1 week

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 39662
Build 36551: arc lint + arc unit

Event Timeline

markj created this revision.Jun 2 2021, 1:55 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 2 2021, 1:55 PM
markj requested review of this revision.Jun 2 2021, 1:55 PM
Harbormaster completed remote builds in B39662: Diff 90320.Jun 2 2021, 1:55 PM
harti added a comment.Jun 2 2021, 2:13 PM

This looks good to me. Good catch.

harti

This revision was not accepted when it landed; it landed in state Needs Review.Jun 6 2021, 8:47 PM
Closed by commit rGe755e2776ddf: ngatm: Handle errors from uni_msg_extend() (authored by markj). · Explain Why
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGe755e2776ddf: ngatm: Handle errors from uni_msg_extend().

Revision Contents
Changeset List

PathSize
sys/
contrib/
ngatm/
netnatm/
msg/
6 lines

Diff 90320

View Options

sys/contrib/ngatm/netnatm/msg/uni_ie.c

Loading...