ls(1): Allow LSCOLORS to specify an underline

[me_cameronkatri.com]

Summary

Allows capitalizing the background color character to unable an underline instead of bold, capitalizing the foreground color char will still do bold.

[pstef]

Like in another differential, I'm making a style-related note from a quick glance just to subscribe to this review. But I want to test this more thoroughly.

bin/ls/print.c

698–704

style(9) is not clear on this, but I believe that by our convention, objects of type other than bool are tested using operators (I mean, for example, pointers compared to NULL, chars compared to '\0' and so on).

[me_cameronkatri.com]

Use operator in if statement.

[pstef]

bin/ls/print.c

706

} else {

[pstef]

bin/ls/print.c

110

Wouldn't bool here be better as a type?

[me_cameronkatri.com]

bin/ls/print.c

110

I used int to follow what was used for bold, but I can change them to be bool if you'd prefer.

[pstef]

bin/ls/print.c

110

I think such a slight inconsistency with the rest of the code would be less bad than using ints for boolean values.

[me_cameronkatri.com]

Use bool for underline and bold.

[me_cameronkatri.com]

I just noticed that when I use git arc it changed the the repository to the subversion one instead of the git. I looks like the /usr/src/.arcconfig is still set to the subversion repo.