Page MenuHomeFreeBSD
Differential D30507

style.9: be explicit about booleans in comparisons
ClosedPublic
Actions

Authored by emaste on May 27 2021, 1:32 PM.
Tags
None
Referenced Files
F102982751: D30507.diff
Tue, Nov 19, 11:26 AM
Unknown Object (File)
Sun, Nov 17, 10:07 AM
Unknown Object (File)
Sun, Nov 17, 10:02 AM
Unknown Object (File)
Thu, Nov 14, 5:44 PM
Unknown Object (File)
Thu, Nov 14, 4:26 PM
Unknown Object (File)
Thu, Nov 14, 9:53 AM
Unknown Object (File)
Wed, Nov 13, 4:49 PM
Unknown Object (File)
Tue, Nov 12, 5:56 PM
View All 12 Files
Subscribers
None

Details

Reviewers
imp
Commits
rGfcd8e27dcf38: style.9: be explicit about booleans in comparisons
rG93f7a3023c31: style.9: be explicit about booleans in comparisons
Summary

We prefer if (count > 0) to if (count) (non-boolean variables) but this is not mentioned in style.9. Make it explicit.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste requested review of this revision.May 27 2021, 1:32 PM
emaste created this revision.
emaste added a comment.May 27 2021, 1:35 PM

Maybe should downgrade the statement to something like "if (count > 0) is preferred over if (count)"

imp added inline comments.May 27 2021, 1:38 PM
share/man/man9/style.9
762

s/Use/Prefer

emaste updated this revision to Diff 90009.May 27 2021, 1:50 PM

Incorporate imp's feedback and reword sentence slightly

emaste updated this revision to Diff 90011.May 27 2021, 1:53 PM

Reword sentence once more to tie in better to the example

imp accepted this revision.May 27 2021, 2:06 PM

I'm good either way: with or without my suggestion.

This revision is now accepted and ready to land.May 27 2021, 2:06 PM
imp added a comment.May 27 2021, 2:06 PM

hit approve on earlier version, but I like the current one even better.

Closed by commit rG93f7a3023c31: style.9: be explicit about booleans in comparisons (authored by emaste). · Explain WhyTue, Nov 12, 5:27 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG93f7a3023c31: style.9: be explicit about booleans in comparisons.
emaste added a commit: rGfcd8e27dcf38: style.9: be explicit about booleans in comparisons.Thu, Nov 14, 12:50 AM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
15 lines

Diff 146329

View Options

share/man/man9/style.9

Loading...