Differential D30455

Unstaticize parts of coredumping code
ClosedPublic
Actions

Authored by trasz on May 25 2021, 4:40 PM.

Details

Reviewers

kib

Commits

rG9fdb30b9167c: Unstaticize parts of coredumping code
rG905d192d6f16: Unstaticize parts of coredumping code

Summary

This makes it possible to call elfN(size_segments) and elfN(puthdr)
from Linux coredump code.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.May 25 2021, 4:40 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 25 2021, 4:40 PM

trasz requested review of this revision.May 25 2021, 4:40 PM

Harbormaster completed remote builds in B39445: Diff 89829.May 25 2021, 4:40 PM

kib added inline comments.May 25 2021, 4:52 PM

sys/kern/imgact_elf.c
1645	You dropped flags, I do not like it.
sys/sys/imgact_elf.h
105	I do not see much sense in this comment.

Restore flags, improve comments, style.

Harbormaster completed remote builds in B39446: Diff 89831.May 25 2021, 5:18 PM

kib accepted this revision.May 25 2021, 5:40 PM

This revision is now accepted and ready to land.May 25 2021, 5:40 PM

Closed by commit rG905d192d6f16: Unstaticize parts of coredumping code (authored by trasz). · Explain WhyMay 26 2021, 10:52 AM

This revision was automatically updated to reflect the committed changes.

trasz added a commit: rG905d192d6f16: Unstaticize parts of coredumping code.

jhb added a commit: rG9fdb30b9167c: Unstaticize parts of coredumping code.May 12 2022, 10:57 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

imgact_elf.c

23 lines

sys/

imgact_elf.h

8 lines

Diff 89893

View Options

sys/kern/imgact_elf.c