Page MenuHomeFreeBSD
Differential D30369

Refactor core dumping code a bit
ClosedPublic
Actions

Authored by trasz on May 20 2021, 8:56 PM.
Tags
None
Referenced Files
F97664240: D30369.id89560.diff
Mon, Sep 30, 4:11 PM
Unknown Object (File)
Sat, Sep 28, 9:21 PM
Unknown Object (File)
Thu, Sep 26, 7:28 PM
Unknown Object (File)
Thu, Sep 26, 2:18 AM
Unknown Object (File)
Thu, Sep 26, 2:08 AM
Unknown Object (File)
Thu, Sep 26, 2:04 AM
Unknown Object (File)
Wed, Sep 25, 2:06 PM
Unknown Object (File)
Wed, Sep 25, 8:17 AM
View All 46 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rGff0179726635: Refactor core dumping code a bit
rG33621dfc196e: Refactor core dumping code a bit
Summary

This makes it possible to use core_write(), core_output(),
and sbuf_drain_core_output(), in Linux coredump code. Moving
them out of imgact_elf.c is necessary because of the weird way
it's being built.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

trasz created this revision.May 20 2021, 8:56 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 20 2021, 8:56 PM
trasz requested review of this revision.May 20 2021, 8:56 PM
Harbormaster completed remote builds in B39326: Diff 89560.May 20 2021, 8:56 PM
kib accepted this revision.May 20 2021, 9:38 PM
kib added inline comments.
sys/kern/kern_exec.c
2015

As a follow-up, please somewhat clean this function:

  • rename 'p' to e.g. cp
  • add local var p for cp->td->td_proc and use it
This revision is now accepted and ready to land.May 20 2021, 9:38 PM
trasz added a comment.May 21 2021, 7:24 PM

(Tinderboxed.)

Closed by commit rG33621dfc196e: Refactor core dumping code a bit (authored by trasz). · Explain WhyMay 22 2021, 9:07 AM
This revision was automatically updated to reflect the committed changes.
trasz added a commit: rG33621dfc196e: Refactor core dumping code a bit.
trasz added inline comments.May 22 2021, 9:12 AM
sys/kern/kern_exec.c
2015

https://reviews.freebsd.org/D30397

jhb added a commit: rGff0179726635: Refactor core dumping code a bit.May 12 2022, 10:57 PM

Revision Contents
Changeset List

PathSize
sys/
kern/
160 lines
147 lines
sys/
19 lines

Diff 89648

View Options

sys/kern/imgact_elf.c

Loading...
View Options

sys/kern/kern_exec.c

Loading...
View Options

sys/sys/exec.h

Loading...