Page MenuHomeFreeBSD

libalias: Remove unused function LibAliasCheckNewLink
ClosedPublic

Authored by donner on May 15 2021, 1:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 2:41 PM
Unknown Object (File)
Sun, Oct 27, 11:32 AM
Unknown Object (File)
Oct 8 2024, 10:42 PM
Unknown Object (File)
Oct 2 2024, 6:31 PM
Unknown Object (File)
Sep 23 2024, 11:20 PM
Unknown Object (File)
Sep 23 2024, 6:52 PM
Unknown Object (File)
Sep 23 2024, 2:45 PM
Unknown Object (File)
Sep 22 2024, 3:59 AM
Subscribers

Details

Summary

The functionality to detect a newly created link after processing a
single packet is decoupled from the packet processing. Every new
packet is processed asynchronously and wil reset the indicator, hence
the function is unusable. I made a Google search for third party code,
which uses the function, and failed to find one.

That's why the function should be removed: It unusable and unused.

Test Plan

Recompile without errors.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

struct libalias is exposed to userspace, right? It looks like nothing in userspace uses it. Or at least in the base system. I don't know if there are ports that care about this.

Edit: It appears you've searched and not found any.
It may be useful to at least have a comment next to the field to indicate it's unused. Ideally it should just be removed, but that'll result in ABI changes, so it makes sense to keep it.

  • Reestablish ABI without providing any functionality.
  • Remove the last piece from the internal structure.
In D30275#680105, @kp wrote:

struct libalias is exposed to userspace, right?

No. It's an opaque type, which is instantiated by library functions.

It may be useful to at least have a comment next to the field to indicate it's unused.
Ideally it should just be removed, but that'll result in ABI changes, so it makes sense to keep it.

Done, keep the ABI function call at least for anything up to 13.

bcr added a subscriber: bcr.

OK from manpages.

This revision was not accepted when it landed; it landed in state Needs Review.May 31 2021, 11:05 AM
This revision was automatically updated to reflect the committed changes.