Page MenuHomeFreeBSD
Differential D30083

service/ipfw: Silence warning on restart
ClosedPublic
Actions

Authored by donner on May 2 2021, 8:51 PM.
Tags
None
Referenced Files
F102048975: D30083.diff
Wed, Nov 6, 11:35 PM
Unknown Object (File)
Fri, Nov 1, 2:01 AM
Unknown Object (File)
Oct 2 2024, 3:14 PM
Unknown Object (File)
Oct 2 2024, 8:27 AM
Unknown Object (File)
Oct 1 2024, 11:25 PM
Unknown Object (File)
Oct 1 2024, 10:14 PM
Unknown Object (File)
Sep 30 2024, 12:07 AM
Unknown Object (File)
Sep 29 2024, 6:49 PM
View All 50 Files
Subscribers
imp
jlduran
kp
Contributor Reviews (src)

Details

Reviewers
kp
Group Reviewers
security
network
Commits
rG370c8a1f784c: service/ipfw: Silence warning on restart
rG9ad87c22530d: service/ipfw: Silence warning on restart
rGe0f2b8aaf1ed: service/ipfw: Silence warning on restart
rG5c4fe2ac81a5: service/ipfw: Silence warning on restart
Summary

Once the ipfw0 interface has been created, ifconfig(8) create will
throw a warning: ifconfig: create: bad value' when trying to create it
again.

PR: 241013
Submitted by: Jose Luis Duran
MFC after: 2 weeks

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38969
Build 35858: arc lint + arc unit

Event Timeline

donner created this revision.May 2 2021, 8:51 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptMay 2 2021, 8:51 PM
donner requested review of this revision.May 2 2021, 8:51 PM
Harbormaster completed remote builds in B38969: Diff 88511.May 2 2021, 8:51 PM
donner added reviewers: security, network.May 2 2021, 8:54 PM
jlduran added a subscriber: jlduran.May 2 2021, 8:56 PM
jlduran added a comment.May 2 2021, 9:07 PM

The idea was to make it more in line with pflog's behavior, and of course to silence the warning. The patch is good as is for me, however.

Thank you for reviewing this.

donner added a reviewer: kp.May 2 2021, 10:17 PM
donner added a subscriber: kp.

Add @kp for the pflog reference.

kp accepted this revision as: kp.May 3 2021, 9:40 AM
kp added inline comments.
libexec/rc/rc.d/ipfw
82

I think I wouldn't include this warning. After all, the system state is what we wanted it to be: we want ipfw0 to exist and it does.

This revision is now accepted and ready to land.May 3 2021, 9:40 AM
Closed by commit rG5c4fe2ac81a5: service/ipfw: Silence warning on restart (authored by donner). · Explain WhyMay 3 2021, 10:30 AM
This revision was automatically updated to reflect the committed changes.
donner marked an inline comment as done.
donner added a commit: rG5c4fe2ac81a5: service/ipfw: Silence warning on restart.
donner added a commit: rGe0f2b8aaf1ed: service/ipfw: Silence warning on restart.May 17 2021, 6:10 AM
donner added a commit: rG9ad87c22530d: service/ipfw: Silence warning on restart.May 17 2021, 6:13 AM
donner added a commit: rG370c8a1f784c: service/ipfw: Silence warning on restart.May 17 2021, 6:17 AM

Revision Contents
Changeset List

PathSize
libexec/
rc/
rc.d/
10 lines

Diff 88511

View Options

libexec/rc/rc.d/ipfw

Loading...