There's a problem with pf's reassembly code where it produces incorrect
checksums when reassembling across interfaces with different MTUs.
Test this.
PR: 255432
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")
Differential D30013
pf tests: Test scrub fragment reassemble on interfaces with different MTU kp on Apr 27 2021, 6:49 PM. Authored by Tags None Referenced Files
Details
There's a problem with pf's reassembly code where it produces incorrect PR: 255432
Diff Detail
Event TimelineComment Actions How do you ensure, that the packet is indeed reassembled by pf and not by the receiving stack? Comment Actions There's no explicit verification for that here. I suppose that if pf did nothing at all this test would still pass. I suppose we could verify the counters on the scrub rule, but that would still only confirm that pf counted the packets and not that it actually reassembled the packet. Comment Actions Interesting idea, but no, pf doesn't look at the fragmentation flag. Not for filtering anyway. |