cp(1): Make -P work without -R as per POSIX

[me_cameronkatri.com]

Summary

According to POSIX, cp should allow the -P flag to work whether -R is specified or not. Currently, the -P option only works along with -R.

PR: 199466

[imp]

The man page isn't very clear, but the code looks right.

bin/cp/cp.1

90

This isn't quite right.

It's only default if -H or -L aren't specified. This language is also hard to understand.

[me_cameronkatri.com]

Make manpage be more clear.

[me_cameronkatri.com]

bin/cp/cp.1

90

Hopefully this is better.

[pstef]

Would you like to add some tests to cp_test.sh?

[me_cameronkatri.com]

Add a test case.

[debdrup]

bin/cp/cp.1

35

.Dd needs to be bumped to today.

[me_cameronkatri.com]

Update .Dd

[me_cameronkatri.com]

Update manpage date.

[gbe]

LGTM for the man page part.

[pauamma_gundo.com]

cp [-R [-H | -L | -P]] in the synopsis needs to be changed if -P can be used without -R.

[me_cameronkatri.com]

In D30012#760630, @pauamma_gundo.com wrote:

cp [-R [-H | -L | -P]] in the synopsis needs to be changed if -P can be used without -R.

How is that supposed to look? Just move the -P out of the []? But -P still can't be used with -H or -L.

[pauamma_gundo.com]

In D30012#760665, @me_cameronkatri.com wrote:

In D30012#760630, @pauamma_gundo.com wrote:

cp [-R [-H | -L | -P]] in the synopsis needs to be changed if -P can be used without -R.

How is that supposed to look? Just move the -P out of the []? But -P still can't be used with -H or -L.

Can -H or -L also be used without -P, or do they require it? What happens it you use 2 (or all 3) of -H, -L, and -P? Latest wins silently? Error? Something else?

[me_cameronkatri.com]

In D30012#761215, @pauamma_gundo.com wrote:

In D30012#760665, @me_cameronkatri.com wrote:

In D30012#760630, @pauamma_gundo.com wrote:

cp [-R [-H | -L | -P]] in the synopsis needs to be changed if -P can be used without -R.

How is that supposed to look? Just move the -P out of the []? But -P still can't be used with -H or -L.

Can -H or -L also be used without -P, or do they require it? What happens it you use 2 (or all 3) of -H, -L, and -P? Latest wins silently? Error? Something else?

-H, -L, and -P conflict, the last one specified will silently win. -H and -L require -R, but -P does not.

[pauamma_gundo.com]

In D30012#770022, @me_cameronkatri.com wrote:

In D30012#761215, @pauamma_gundo.com wrote:

In D30012#760665, @me_cameronkatri.com wrote:

In D30012#760630, @pauamma_gundo.com wrote:

cp [-R [-H | -L | -P]] in the synopsis needs to be changed if -P can be used without -R.

How is that supposed to look? Just move the -P out of the []? But -P still can't be used with -H or -L.

Can -H or -L also be used without -P, or do they require it? What happens it you use 2 (or all 3) of -H, -L, and -P? Latest wins silently? Error? Something else?

-H, -L, and -P conflict, the last one specified will silently win. -H and -L require -R, but -P does not.

Then I'd go with either a single line:

cp [-R [-H | -L] | -P |-R]]

or two separate lines:

cp [-R [-H | -L]]
cp [-P [-R]]

The latter looks clearer to me.

[me_cameronkatri.com]

Rebase after 848263aad129c8f9de75b58a5ab9a010611b75ac
Make SYNOPSIS more clear

[me_cameronkatri.com]

Update manpage date.

[kevans]

I will take this; I have further changes in the area.

[me_cameronkatri.com]

Rebase after 33ad990

[me_cameronkatri.com]

Update manpage date

[kevans]

I will commit this tomorrow afternoon-ish. Thanks! Can you confirm that this is your preferred name + email, please? --author="Cameron Katri <[e-mail]>"

[me_cameronkatri.com]

In D30012#777995, @kevans wrote:

I will commit this tomorrow afternoon-ish. Thanks!

Thank you.

Can you confirm that this is your preferred name + email, please? --author="Cameron Katri <[e-mail]>"

Yes, that's correct.