Page MenuHomeFreeBSD

aesni: Avoid modifying session keys in hmac_update()
ClosedPublic

Authored by markj on Apr 27 2021, 12:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 3:30 PM
Unknown Object (File)
Tue, Jan 14, 12:57 AM
Unknown Object (File)
Dec 11 2024, 4:55 AM
Unknown Object (File)
Dec 4 2024, 7:17 PM
Unknown Object (File)
Dec 3 2024, 4:15 PM
Unknown Object (File)
Oct 20 2024, 3:45 PM
Unknown Object (File)
Oct 5 2024, 1:04 AM
Unknown Object (File)
Oct 5 2024, 1:04 AM
Subscribers
None

Details

Summary

Otherwise aesni_process() is not thread-safe for AES+SHA-HMAC
transforms, since hmac_update() updates the caller-supplied key directly
to create the derived key. Use a buffer on the stack to store a copy of
the key used for computing inner and outer digests.

Note that this applies to stable/12 only.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 38878
Build 35767: arc lint + arc unit

Event Timeline

markj created this revision.
This revision is now accepted and ready to land.Apr 27 2021, 2:09 PM