Page MenuHomeFreeBSD

tcp: stop spurious rescue retransmissions
ClosedPublic

Authored by rscheff on Apr 25 2021, 11:03 AM.
Tags
None
Referenced Files
F115983267: D29970.diff
Thu, May 1, 5:04 AM
Unknown Object (File)
Tue, Apr 22, 10:51 PM
Unknown Object (File)
Fri, Apr 18, 10:33 PM
Unknown Object (File)
Tue, Apr 1, 2:10 PM
Unknown Object (File)
Mar 18 2025, 12:11 AM
Unknown Object (File)
Feb 25 2025, 6:54 AM
Unknown Object (File)
Feb 22 2025, 8:56 AM
Unknown Object (File)
Feb 19 2025, 8:55 PM
Subscribers

Details

Summary

As stale data from a prior SACK loss recovery episode persists,
a subsequent reordering event may trigger a spurious rescue
retransmission, which in turn misbehaves due to other stale
data.

To prevent sending an erraneous rescue retransmission, clear
the sackhint.delivered_data value, once finished with a SACK
loss recovery.

Furthermore, initialize snd_fack to th_ack on a partial ack,
to pull it forward from whereever the last proper SACK may
have been.

Test Plan

Perform long-duration testing with a low background of packet
reordering and very few losses (or sufficient reordering for
dupthresh to be exceeded).

Reported by: pho@
MFC after: 3 days
Sponsored by: NetApp, Inc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38851
Build 35740: arc lint + arc unit