Page MenuHomeFreeBSD

[rtsock] Enforce netmask/RTF_HOST consistency
ClosedPublic

Authored by melifaro on Apr 23 2021, 9:54 PM.
Tags
None
Referenced Files
F102164054: D29958.diff
Fri, Nov 8, 9:55 AM
Unknown Object (File)
Sat, Nov 2, 5:35 AM
Unknown Object (File)
Sun, Oct 13, 3:14 AM
Unknown Object (File)
Sun, Oct 13, 3:14 AM
Unknown Object (File)
Sun, Oct 13, 3:14 AM
Unknown Object (File)
Sun, Oct 13, 3:06 AM
Unknown Object (File)
Oct 4 2024, 4:04 PM
Unknown Object (File)
Oct 4 2024, 8:55 AM
Subscribers

Details

Summary

Traditionally we had 2 sources of information whether the added/delete route request targets network or a host route:
netmask (RTA_NETMASK) and RTF_HOST flag.

The former one is tricky: netmask can be empty or can explicitly specify the host netmask. Parsing netmask sockaddr requires per-family parsing and that's what rtsock code traditionally avoided. As a result, consistency was not enforced and it was possible to specify network with the RTF_HOST flag and vice versa.

Continue normalization efforts from D29826 and D29826 and ensure that RTF_HOST flag always reflects host/network data from netmask field.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable