Improve debugging output on routing tests failure
ClosedPublic
Actions

Authored by melifaro on Apr 23 2021, 9:34 PM.

Details

Reviewers

Group Reviewers

network

Commits

rGfe04896da3fb: Improve debugging output on routing tests failure.
rGbddae5c8a64d: Improve debugging output on routing tests failure.

Summary

Most of the routing tests create per-test VNET, making it harder to repeat the failure with CLI tools.
Provide an additional route/nexthop data on failure.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

melifaro requested review of this revision.Apr 23 2021, 9:34 PM

melifaro created this revision.

Harbormaster completed remote builds in B38835: Diff 88060.Apr 23 2021, 9:35 PM

Harbormaster completed remote builds in B38836: Diff 88061.Apr 23 2021, 9:35 PM

melifaro retitled this revision from Summary: Improve debugging output on routing tests failure to Improve debugging output on routing tests failure.Apr 23 2021, 9:37 PM

melifaro edited the summary of this revision. (Show Details)

melifaro added a reviewer: network.

kp added a subscriber: kp.Apr 23 2021, 9:45 PM

kp added inline comments.

tests/sys/net/routing/rtsock_print.h
404	It looks like line is unused here.
409	I think you can just `system(cmdbuf);` here. That'll fork a shell and inherit our stdout/stderr, so it should do what you want with less effort.

melifaro added inline comments.Apr 23 2021, 11:10 PM

tests/sys/net/routing/rtsock_print.h
409	I started with that. Due to either buffering or other issues the output from system() calls appears on top, before any other logs, thus making it harder to find/interpret.