This logic was accidentally changed in 67f2f67fc8ce8484066e95dabac5af892888fca1
Reported By: olivier
X-MFC-With: 67f2f67fc8ce8484066e95dabac5af892888fca1
Fixes: 67f2f67fc8ce ("Update rtsock_l3 test after 2fe5a79425c7")
Details
Details
- Reviewers
olivier kp melifaro - Group Reviewers
network - Commits
- rG694407528fb5: Correctly skip rtsock_l3 test when if_epair is not available
Untested since I don't have a kernel without if_epair, but should hopefully work.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 38825 Build 35714: arc lint + arc unit
Event Timeline
Comment Actions
Skips correctly if if_epair.ko cannot be loaded (tested with sudo rm /boot/kernel/if_epair.ko).
Comment Actions
Thanks!
it fixes the regression:
# grep 'rtsock_l3.*skipped: module if_epair could not be resolve' test-report-freebsd.txt sys/net/routing/test_rtsock_l3:rtm_add_v4_gu_ifa_ordered_success -> skipped: module if_epair could not be resolved: No such file or directory [0.003s] sys/net/routing/test_rtsock_l3:rtm_add_v4_gw_direct_success -> skipped: module if_epair could not be resolved: No such file or directory [0.003s] sys/net/routing/test_rtsock_l3:rtm_add_v4_no_rtf_host_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] sys/net/routing/test_rtsock_l3:rtm_add_v4_temporal1_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] sys/net/routing/test_rtsock_l3:rtm_add_v6_gu_gw_gu_direct_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] sys/net/routing/test_rtsock_l3:rtm_add_v6_temporal1_success -> skipped: module if_epair could not be resolved: No such file or directory[0.004s] sys/net/routing/test_rtsock_l3:rtm_change_v4_flags_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] sys/net/routing/test_rtsock_l3:rtm_change_v4_gw_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] sys/net/routing/test_rtsock_l3:rtm_change_v4_mtu_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] sys/net/routing/test_rtsock_l3:rtm_change_v6_flags_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] sys/net/routing/test_rtsock_l3:rtm_change_v6_gw_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] sys/net/routing/test_rtsock_l3:rtm_change_v6_mtu_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] sys/net/routing/test_rtsock_l3:rtm_del_v4_gu_ifa_prefixroute_success -> skipped: module if_epair could not be resolved: No such file or directory [0.004s] (...)