libkiconv: address memory leak in a not-found case
ClosedPublic
Actions

Authored by emaste on Apr 21 2021, 5:48 PM.

Details

Reviewers

scottl
imp
jhb

Commits

rG8e64d97d94f7: libkiconv: address memory leak in not-found cases
rG7452b2e44be6: libkiconv: address memory leak in not-found cases
rGe3bbb369c44b: libkiconv: address memory leak in not-found cases
rG3cfd08c1c740: libkiconv: address memory leak in not-found cases

Summary

Found in "Understanding and Detecting Disordered Error Handling with Precise Function Pairing" by Qiushi Wu et. al.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Apr 21 2021, 5:48 PM

emaste created this revision.

scottl requested changes to this revision.Apr 21 2021, 5:59 PM

scottl added a subscriber: scottl.

scottl added inline comments.

lib/libkiconv/kiconv_sysctl.c
90	Do you mean `free(csi)` here?

This revision now requires changes to proceed.Apr 21 2021, 5:59 PM

fix from scott

paper was here: https://www-users.cs.umn.edu/~kjlu/papers/hero.pdf

imp accepted this revision.Apr 21 2021, 6:16 PM

RAII would be nice.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 22 2021, 11:34 PM

Closed by commit rG3cfd08c1c740: libkiconv: address memory leak in not-found cases (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG3cfd08c1c740: libkiconv: address memory leak in not-found cases.

emaste added a commit: rGe3bbb369c44b: libkiconv: address memory leak in not-found cases.Apr 28 2021, 12:11 AM

emaste added a commit: rG7452b2e44be6: libkiconv: address memory leak in not-found cases.

emaste added a commit: rG8e64d97d94f7: libkiconv: address memory leak in not-found cases.

Revision Contents
Changeset List

Path

Size

lib/

libkiconv/

kiconv_sysctl.c

2 lines

Diff 87886

View Options

lib/libkiconv/kiconv_sysctl.c

libkiconv: address memory leak in a not-found caseClosedPublicActions