Remove name mangling in generate-ucl.sh

[markj]

Summary

I don't plan to commit this yet, as we're not sure why the name mangling
was there to begin with. r364009 introduced a regression for packages
containing a "_" in the name, such as libcompiler_rt. Removing the name
mangling fixes the problem.

Test Plan

I no longer see errors about missing dependencies when installing base packages.

[freebsd_igalic.co]

i wonder if this regression is the cause of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254173

[markj]

In D29883#670691, @me_igalic.co wrote:

i wonder if this regression is the cause of https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=254173

It doesn't seem so. There is a missing dependency specification: ld actually depends on the -dev package for a couple of libraries, as you found. In particular, clibs-dev, libcompiler_rt-dev and utilities-dev are all required in order to dynamically link a program.

I think this is indeed a bug. Other -dev packages don't explicitly depend on the "core" -dev packages either.

[manu]

I don't remember why I did this but yes this solve some dependencies issues.

[markj]

In D29883#672527, @manu wrote:

I don't remember why I did this but yes this solve some dependencies issues.

Ok, thanks. I think I will go ahead and commit this with a generous MFC period to see if I break anything. The original name mangling was added long enough ago that I want to believe that whatever problem it solved no longer exists.

[manu]

In D29883#672874, @markj wrote:

In D29883#672527, @manu wrote:

I don't remember why I did this but yes this solve some dependencies issues.

Ok, thanks. I think I will go ahead and commit this with a generous MFC period to see if I break anything. The original name mangling was added long enough ago that I want to believe that whatever problem it solved no longer exists.

Yes I believe that too.