Add more checking for unmapped mbufs
ClosedPublic
Actions

Authored by markj on Apr 19 2021, 3:40 PM.

Details

Reviewers

ae
tuexen
jhb
gallatin

Commits

rG2b826286c3b9: Add required checks for unmapped mbufs in ipdivert and ipfw
rG652908599b6f: Add required checks for unmapped mbufs in ipdivert and ipfw

Summary

ipdivert and ipfw nat64 need to handle unmapped mbufs
Add a M_ASSERTMAPPED() assertion which verifies that all mbufs in a chain are mapped.
Use M_ASSERTMAPPED() in ipfw nat. m_megapullup() returns mapped mbuf clusters.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38688
Build 35577: arc lint + arc unit

Event Timeline

markj created this revision.Apr 19 2021, 3:40 PM

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptApr 19 2021, 3:40 PM

markj requested review of this revision.Apr 19 2021, 3:40 PM

Harbormaster completed remote builds in B38688: Diff 87717.Apr 19 2021, 3:40 PM

markj added reviewers: ae, tuexen, jhb, gallatin.Apr 19 2021, 3:40 PM

gallatin accepted this revision.Apr 19 2021, 4:15 PM

This revision is now accepted and ready to land.Apr 19 2021, 4:15 PM

ae accepted this revision.Apr 20 2021, 4:48 AM

Closed by commit rG652908599b6f: Add required checks for unmapped mbufs in ipdivert and ipfw (authored by markj). · Explain WhyApr 21 2021, 8:00 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG652908599b6f: Add required checks for unmapped mbufs in ipdivert and ipfw.

markj added a commit: rG2b826286c3b9: Add required checks for unmapped mbufs in ipdivert and ipfw.Apr 28 2021, 2:10 PM

sobomax mentioned this in D43776: Disambiguate KASSERTs in the m_apply() mbuf checking code and provide more context.Feb 7 2024, 1:40 AM

Revision Contents
Changeset List

Path

Size

sys/

netinet/

ip_divert.c

6 lines

netpfil/

ipfw/

ip_fw_nat.c

1 line

nat64/

nat64_translate.c

10 lines

sys/

mbuf.h

10 lines

Diff 87717

View Options

sys/netinet/ip_divert.c

View Options

sys/netpfil/ipfw/ip_fw_nat.c

View Options

sys/netpfil/ipfw/nat64/nat64_translate.c

View Options

Add more checking for unmapped mbufsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 87717

sys/netinet/ip_divert.c

sys/netpfil/ipfw/ip_fw_nat.c

sys/netpfil/ipfw/nat64/nat64_translate.c

sys/sys/mbuf.h

Add more checking for unmapped mbufs
ClosedPublic
Actions

Revision Contents
Changeset List