linkat(2): check NIRES_EMPTYPATH on the first fd arg
ClosedPublic
Actions

Authored by kib on Apr 19 2021, 1:38 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sep 26 2024, 3:26 AM

	Unknown Object (File)
	Sep 24 2024, 8:27 AM

	Unknown Object (File)
	Sep 24 2024, 7:00 AM

	Unknown Object (File)
	Sep 23 2024, 11:21 PM

	Unknown Object (File)
	Sep 21 2024, 11:26 AM

	Unknown Object (File)
	Sep 20 2024, 3:09 AM

	Unknown Object (File)
	Sep 11 2024, 2:17 AM

	Unknown Object (File)
	Sep 9 2024, 4:36 AM

View All 53 Files

Subscribers

None

Details

Reviewers

arichardson
markj

Commits

rG578c26f31c0c: linkat(2): check NIRES_EMPTYPATH on the first fd arg

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib requested review of this revision.Apr 19 2021, 1:38 PM

kib created this revision.

markj added inline comments.Apr 19 2021, 1:47 PM

sys/kern/vfs_syscalls.c
1581	How can it be null? kern_linkat_vp() dereferences nd.ni_vp unconditionally.

markj accepted this revision.Apr 19 2021, 1:51 PM

This revision is now accepted and ready to land.Apr 19 2021, 1:51 PM

kib marked an inline comment as done.Apr 19 2021, 3:02 PM

kib added inline comments.

sys/kern/vfs_syscalls.c
1581	Yes, LOOKUP only returns success when there is something to lookup.

Remove ni_vp != NULL check.

This revision now requires review to proceed.Apr 19 2021, 3:03 PM

markj accepted this revision.Apr 19 2021, 3:04 PM

This revision is now accepted and ready to land.Apr 19 2021, 3:04 PM

Closed by commit rG578c26f31c0c: linkat(2): check NIRES_EMPTYPATH on the first fd arg (authored by kib). · Explain WhyApr 19 2021, 6:32 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG578c26f31c0c: linkat(2): check NIRES_EMPTYPATH on the first fd arg.

Revision Contents
Changeset List

Path

Size

sys/

kern/

vfs_syscalls.c

25 lines

Diff 87703

View Options

linkat(2): check NIRES_EMPTYPATH on the first fd argClosedPublicActions