IEEE Std 802.1D-2004 Section 17.14 defines permitted ranges for timers.
Incoming BPDU messages should be checked against the permitted ranges.
The rest of 17.14 appears to be enforced already.
PR: 254924
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 38601 Build 35490: arc lint + arc unit
Event Timeline
| sys/net/bridgestp.c | ||
|---|---|---|
| 604–605 | No, BSTP_MIN_MAX_AGE is still acceptable. The cu_max_age value should only be rejected if it's strictly less than that value. (Or more than the maximum value). See also bstp_set_maxage() for example. | |
| 613 | Yes. I checked the couch and found a loose space, so I don't have to run to the store to buy more. | |
| sys/net/bridgestp.c | ||
|---|---|---|
| 613 | May you insert the space into the code like this? cu->cu_hello_time > BSTP_MAX_HELLO_TIME | |
| sys/net/bridgestp.c | ||
|---|---|---|
| 613 | Yes, I've applied that change in my local version of this commit and it'll be included when I push this later today. | |