sndstat: nvlist schema and API definition changes
ClosedPublic
Actions

Authored by khng on Apr 15 2021, 9:10 AM.

Details

Reviewers

• hselasky
philip

Group Reviewers

manpages

Commits

rG4ce1ba652383: sndstat: nvlist schema and API definition changes

Summary

SNDSTAT_LABEL_* are renamed to SNDST_DSPS_*, and SNDSTAT_LABEL_DSPS becomes SNDST_DSPS.
Centralize channel number/rate/formats into a single nvlist The above nvlist is named "info_play" and "info_rec"
Expose only encoding format in pfmts/rfmts. Userland has no direct access to AFMT_ENCODING/CHANNEL/EXTCHANNEL macros, thus it serves no meaning to expose too much information through this pair of labels. However pminrate/rminrate, pmaxrate/rmaxrate, pfmts/rfmts are deprecated and will be removed in future.

This commit keeps ioctls ABI compatibility with __FreeBSD_version
1400006 for now. In future the compat ABI with 1400006 will be removed
once audio/virtual_oss is rebuilt.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38584
Build 35473: arc lint + arc unit

Event Timeline

khng created this revision.Apr 15 2021, 9:10 AM

Herald added a reviewer: manpages. · View Herald TranscriptApr 15 2021, 9:10 AM

Herald added a subscriber: imp. · View Herald Transcript

khng requested review of this revision.Apr 15 2021, 9:10 AM

Harbormaster completed remote builds in B38583: Diff 87462.Apr 15 2021, 9:10 AM

khng added a reviewer: • hselasky.Apr 15 2021, 9:11 AM

Found 3 typos, one of which was not yours. :-)

share/man/man4/sndstat.4
102	s/support/supports/
118	See above.
140–141	Oh look, a typo in the man page that was there before your change. Oops: s/providede/provided/ You could fix this while you're here.