Page MenuHomeFreeBSD

qlnxr: Properly initialize the Linux device structure
ClosedPublic

Authored by markj on Apr 5 2021, 8:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 15, 11:17 AM
Unknown Object (File)
Sep 24 2024, 8:06 AM
Unknown Object (File)
Sep 24 2024, 2:54 AM
Unknown Object (File)
Sep 23 2024, 3:18 PM
Unknown Object (File)
Sep 23 2024, 10:40 AM
Unknown Object (File)
Sep 9 2024, 2:37 AM
Unknown Object (File)
Sep 9 2024, 2:36 AM
Unknown Object (File)
Sep 8 2024, 5:54 AM
Subscribers

Details

Summary

types.h defines device_t to be a struct device *, but the definition of
struct device is internal to subr_bus. But, the LinuxKPI also defines a
struct device, so type confusion is possible.

In this case, we were copying a FreeBSD device structure into a Linux
device structure. The Linux device structure is only used for the IB
device, for allocating DMA'able memory. I believe the old version
worked more or less by accident.

Use linux_pci_attach_device() instead, following the example of the
Chelso iwarp driver. Also ensure that we don't leak the faked device
during detach.

Test Plan

None, I do not have any way to test this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38342
Build 35231: arc lint + arc unit