Partially revert r248770.
ClosedPublic
Actions

Authored by dchagin on Apr 1 2021, 7:37 PM.

Details

Reviewers

jimharris
mav
imp

Commits

rGa83c64a59cf5: Partially revert r248770.
rG02816ecfb935: Partially revert r248770.
rGa78109d5db87: Partially revert r248770.

Summary

nvme_ns_bio_process() is on the path where sleep is prohibited as
g_io_shedule_down() calls THREAD_NO_SLEEPNG() before geom->start().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dchagin created this revision.Apr 1 2021, 7:37 PM

Herald added subscribers: dab, imp. · View Herald TranscriptApr 1 2021, 7:37 PM

Harbormaster completed remote builds in B38259: Diff 86705.Apr 1 2021, 7:37 PM

dchagin requested review of this revision.Apr 1 2021, 7:37 PM

dchagin added reviewers: jimharris, mav, imp.Apr 1 2021, 7:38 PM

I've never seen this lead to deadlock, but I'm also only ever using nvme with direct dispatch...

This revision is now accepted and ready to land.Apr 1 2021, 8:38 PM

In D29539#662228, @imp wrote:

I've never seen this lead to deadlock, but I'm also only ever using nvme with direct dispatch...

10x, seems that I'm first who use nvme under geom o_O

Closed by commit rGa78109d5db87: Partially revert r248770. (authored by dchagin). · Explain WhyApr 2 2021, 8:44 AM

This revision was automatically updated to reflect the committed changes.

dchagin added a commit: rGa78109d5db87: Partially revert r248770..

dchagin added a commit: rG02816ecfb935: Partially revert r248770..Apr 16 2021, 8:34 AM

dchagin added a commit: rGa83c64a59cf5: Partially revert r248770..Apr 16 2021, 8:36 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

nvme/

nvme_ns.c

2 lines

Diff 86729

View Options

Partially revert r248770.ClosedPublicActions