Page MenuHomeFreeBSD
Differential D29502

Convert the ports(7) manual page to Git.
ClosedPublic
Actions

Authored by rene on Mar 30 2021, 8:03 PM.
Tags
None
Referenced Files
F102217565: D29502.diff
Sat, Nov 9, 2:36 AM
Unknown Object (File)
Fri, Nov 8, 1:20 AM
Unknown Object (File)
Sat, Nov 2, 2:11 AM
Unknown Object (File)
Wed, Oct 30, 4:08 AM
Unknown Object (File)
Tue, Oct 29, 2:13 PM
Unknown Object (File)
Thu, Oct 24, 2:52 AM
Unknown Object (File)
Wed, Oct 23, 4:59 PM
Unknown Object (File)
Tue, Oct 22, 10:16 AM
View All Files
Subscribers
imp
mat

Details

Reviewers
lwhsu
emaste
bapt
gjb
uqs
imp
Group Reviewers
manpages
Commits
rG11f47f17e122: ports(7): update instructions for git

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38194
Build 35083: arc lint + arc unit

Event Timeline

rene created this revision.Mar 30 2021, 8:03 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 30 2021, 8:03 PM
rene requested review of this revision.Mar 30 2021, 8:03 PM
Harbormaster completed remote builds in B38192: Diff 86574.Mar 30 2021, 8:03 PM
gjb accepted this revision.Mar 30 2021, 8:08 PM
gjb added inline comments.
share/man/man7/ports.7
69

I would remove the "(also known as head)", since we are moving away from that terminology.

I will not complain either way, though.

But I would use '.Po/.Pc' macros instead of hard-coded parenthesis.

This revision is now accepted and ready to land.Mar 30 2021, 8:08 PM
lwhsu added inline comments.Mar 30 2021, 8:10 PM
share/man/man7/ports.7
75–79

I think https://svn.freebsd.org/ports/head is a "check out" URL so the counterpart in git would be https://git.freebsd.org/ports , and maybe mention the -b main parameter when doing git clone.

87

Same here.

imp accepted this revision.Mar 30 2021, 8:11 PM

I'm good with this as it is, but if you make my suggested changes I'm good with it too :)

share/man/man7/ports.7
69

Maybe "formerly known as head" if you don't remove it.

87

I'd change this to 2019Q1 to 2021Q1

rene updated this revision to Diff 86575.Mar 30 2021, 8:13 PM
  • Remove obsolete "head" terminology.
This revision now requires review to proceed.Mar 30 2021, 8:13 PM
Harbormaster completed remote builds in B38193: Diff 86575.Mar 30 2021, 8:13 PM
lwhsu added inline comments.Mar 30 2021, 8:14 PM
share/man/man7/ports.7
69

I suggest latest because we use that in /etc/pkg/FreeBSD.conf

lwhsu added inline comments.Mar 30 2021, 8:16 PM
share/man/man7/ports.7
87

We can explain more here, saying that the format is YYYYQN where YYYY is the year and N is the number of the quarter.

gjb added inline comments.Mar 30 2021, 8:20 PM
share/man/man7/ports.7
69

Not for releases, though. The quarterly branch is used in /etc/pkg/FreeBSD.conf there.

rene updated this revision to Diff 86576.Mar 30 2021, 8:34 PM
rene marked 3 inline comments as done.
  • Update the section about branches.
Harbormaster completed remote builds in B38194: Diff 86576.Mar 30 2021, 8:34 PM
lwhsu added inline comments.Mar 30 2021, 8:37 PM
share/man/man7/ports.7
69

Yes which branches are used by which version is explained below. I mean here we can explain that the source of pkg's latest branch is ports' main branch.

84

it's nice to explain what yyyy and n means.

rene updated this revision to Diff 86577.Mar 30 2021, 8:41 PM
  • Use the correct git URL
Harbormaster completed remote builds in B38195: Diff 86577.Mar 30 2021, 8:41 PM
gjb accepted this revision.Mar 30 2021, 8:47 PM
This revision is now accepted and ready to land.Mar 30 2021, 8:47 PM
rene updated this revision to Diff 86579.Mar 30 2021, 8:51 PM
rene marked 7 inline comments as done.
  • Better explain yyyyQn
This revision now requires review to proceed.Mar 30 2021, 8:51 PM
Harbormaster completed remote builds in B38197: Diff 86579.Mar 30 2021, 8:51 PM
rene updated this revision to Diff 86580.Mar 30 2021, 8:53 PM
  • forgot one .git
Harbormaster completed remote builds in B38198: Diff 86580.Mar 30 2021, 8:53 PM
gjb accepted this revision.Mar 30 2021, 8:57 PM
This revision is now accepted and ready to land.Mar 30 2021, 8:57 PM
lwhsu added inline comments.Mar 30 2021, 8:57 PM
share/man/man7/ports.7
83–85

maybe "branches can be found in Git repository's"

mat added a subscriber: mat.Mar 31 2021, 7:45 AM
mat added inline comments.
share/man/man7/ports.7
87

Do we really need the branch/ prefix? It had a meaning when we were using subversion, but now, branches are branches, not subdirectories that we decided to use as a branch.

rene marked 2 inline comments as done.Apr 6 2021, 8:25 PM
rene added inline comments.
share/man/man7/ports.7
87

No :)

Closed by commit rG11f47f17e122: ports(7): update instructions for git (authored by rene). · Explain WhyApr 6 2021, 8:28 PM
This revision was automatically updated to reflect the committed changes.
rene marked an inline comment as done.
rene added a commit: rG11f47f17e122: ports(7): update instructions for git.

Revision Contents
Changeset List

PathSize
share/
man/
man7/
24 lines

Diff 86576

View Options

share/man/man7/ports.7

Loading...