Append Keyboard Layout specified option for using VNC. Part one: supporting QEMU Extended Keyboard Event Message
ClosedPublic
Actions

Authored by mr on Mar 26 2021, 3:50 PM.

Details

Reviewers

Group Reviewers

bhyve
manpages

Commits

rG7c85b2342aa2: Append Keyboard Layout specified option for using VNC.
rGb563ff5d4f81: Append Keyboard Layout specified option for using VNC.

Summary

PR: 246121
Submitted by: koinec@yahoo.co.jp

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38137
Build 35026: arc lint + arc unit

Event Timeline

mr created this revision.Mar 26 2021, 3:50 PM

Herald added a reviewer: bhyve. · View Herald TranscriptMar 26 2021, 3:50 PM

Herald added subscribers: Contributor Reviews (src), bcran, rgrimes, imp. · View Herald Transcript

mr requested review of this revision.Mar 26 2021, 3:50 PM

Harbormaster completed remote builds in B38086: Diff 86346.Mar 26 2021, 3:50 PM

Looks fine: please fix the #define on submit.

usr.sbin/bhyve/rfb.c
1064	This should be a #define, e.g. CS_CLIENTMSG

This revision is now accepted and ready to land.Mar 27 2021, 2:02 AM

Add #define CS_MSG_CLIENT_QEMU and name it to point to Quemu

Updating D29430: Append Keyboard Layout specified option for using VNC.

Part one: supporting QEMU Extended Keyboard Event Message

This revision now requires review to proceed.Mar 28 2021, 1:44 PM

Harbormaster completed remote builds in B38137: Diff 86432.Mar 28 2021, 1:44 PM

grehan accepted this revision.Mar 30 2021, 8:11 AM

This revision is now accepted and ready to land.Mar 30 2021, 8:11 AM

Append Keyboard Layout specified option for using VNC.

Updating D29430: Append Keyboard Layout specified option for using VNC.

Part one: supporting QEMU Extended Keyboard Event Message

This revision now requires review to proceed.Apr 10 2021, 12:11 PM

Herald added a reviewer: manpages. · View Herald TranscriptApr 10 2021, 12:11 PM

Harbormaster completed remote builds in B38482: Diff 87198.Apr 10 2021, 12:11 PM

Sigh, I've updatet the wrong review.
This patch should have gone to the part two...
https://reviews.freebsd.org/D29473

Want to abandon this one and re-submit ?

Hi,

In D29430#666971, @grehan wrote:

Want to abandon this one and re-submit ?

the least effort would be to not touch this review and commit the already reviewed patch to main.
Originally I intended to commit and push this review and the part 2 review https://reviews.freebsd.org/D29473 together...
What do you think?

the least effort would be to not touch this review and commit the already reviewed patch to main.

That's also fine.

Originally I intended to commit and push this review and the part 2 review https://reviews.freebsd.org/D29473 together...
What do you think?

How about committing part 1 now ? That provides an immediate path forward for non-English VNC support, and requires no base system datafiles or man page updates.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 21 2021, 10:43 AM

Closed by commit rGb563ff5d4f81: Append Keyboard Layout specified option for using VNC. (authored by mr). · Explain Why

This revision was automatically updated to reflect the committed changes.

mr added a commit: rGb563ff5d4f81: Append Keyboard Layout specified option for using VNC..

corvink added a commit: rG7c85b2342aa2: Append Keyboard Layout specified option for using VNC..Nov 23 2022, 9:46 AM