gvinum: add deprecation notice
ClosedPublic
Actions

Authored by emaste on Mar 25 2021, 5:59 PM.

Details

Reviewers

imp
jhb

Commits

rG3664eb6ff7fa: gvinum: add deprecation notice
rG42f1df609996: gvinum: add deprecation notice
rGb218441ac074: gvinum: add deprecation notice

Summary

Posted to -stable in https://lists.freebsd.org/pipermail/freebsd-stable/2021-March/093358.html

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste requested review of this revision.Mar 25 2021, 5:59 PM

emaste created this revision.

docs still refer to pre-geom vinum: https://docs.freebsd.org/en/articles/vinum/

If this is somehow still widely used, we can always revert.

This revision is now accepted and ready to land.Mar 25 2021, 7:31 PM

Should we add a 'gone_in()' call somewhere in the kernel as well, e.g. when creating a new gvinum GEOM provider?

sbin/gvinum/gvinum.8
61

In D29424#659116, @jhb wrote:

Should we add a 'gone_in()' call somewhere in the kernel as well, e.g. when creating a new gvinum GEOM provider?

Agreed, but that can be a separate review :)

Add .Xr to replacements, and link to wiki page

This revision now requires review to proceed.Mar 26 2021, 3:36 PM

emaste added inline comments.Mar 26 2021, 3:39 PM

sbin/gvinum/gvinum.8
52	Not sure what the proper markup for a URL is, but I see examples of .Pa in the tree already. manpages?
61	I can see arguments either way; my thinking was that the statement goes in with 'may' initially, and we can change it to 'will' once it's actually removed from current.

@koobs moved the wiki page

Track @koobs wiki move

This revision was not accepted when it landed; it landed in state Needs Review.Mar 28 2021, 6:54 PM

Closed by commit rGb218441ac074: gvinum: add deprecation notice (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGb218441ac074: gvinum: add deprecation notice.

Agreed, but that can be a separate review :)

Humm, we typically do deprecation notices all in one commit (manpage and gone_in).

emaste mentioned this in D29486: geom_vinum: add gone_in deprecation notice.Mar 29 2021, 5:29 PM

In D29424#660129, @emaste wrote:

@koobs moved the wiki page

Apologies, recent edits come up in RecentChanges so they tend to get more eyes and in my case, natural follow-up :)

In D29424#660862, @koobs wrote:

Apologies, recent edits come up in RecentChanges so they tend to get more eyes and in my case, natural follow-up :)

No worries, better that it moved before commit :)

In D29424#660866, @emaste wrote:

In D29424#660862, @koobs wrote:

Apologies, recent edits come up in RecentChanges so they tend to get more eyes and in my case, natural follow-up :)

No worries, better that it moved before commit :)

Definitely. Coincidentally, @lcook and I were *just* talking about "a great redirector" freebsd service, which would have helped in that (unfortunate) case too. *writes notes*.

emaste added a commit: rG42f1df609996: gvinum: add deprecation notice.Dec 3 2021, 3:17 PM

emaste added a commit: rG3664eb6ff7fa: gvinum: add deprecation notice.