Differential D29396

LinuxKPI: add more linux-specific errno
ClosedPublic
Actions

Authored by bz on Mar 23 2021, 4:49 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Sep 29, 7:32 AM

	Unknown Object (File)
	Thu, Sep 26, 4:03 PM

	Unknown Object (File)
	Thu, Sep 26, 12:49 PM

	Unknown Object (File)
	Tue, Sep 24, 8:47 AM

	Unknown Object (File)
	Tue, Sep 24, 3:43 AM

	Unknown Object (File)
	Sat, Sep 21, 11:23 PM

	Unknown Object (File)
	Fri, Sep 6, 5:48 PM

	Unknown Object (File)
	Fri, Sep 6, 5:48 PM

View All 53 Files

Subscribers

Details

Reviewers

• hselasky
emaste

Group Reviewers

Commits

rG36d6711bd68f: LinuxKPI: add more linux-specific errno
rG4b0632cfc5c8: LinuxKPI: add more linux-specific errno

Summary

Add ERFKILL and EBADE found in iwlwifi and brcmfmac wireless drivers.

Obtained-from: bz_iwlwifi
Sponsored-by: The FreeBSD Foundation
MFC-after: 2 weeks
Reviewed-by: ...
Differential Revision:

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38021
Build 34910: arc lint + arc unit

Event Timeline

bz created this revision.Mar 23 2021, 4:49 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptMar 23 2021, 4:49 PM

bz requested review of this revision.Mar 23 2021, 4:49 PM

Harbormaster completed remote builds in B38021: Diff 86207.Mar 23 2021, 4:49 PM

emaste added inline comments.Mar 23 2021, 7:06 PM

sys/compat/linuxkpi/common/include/linux/errno.h
61–62	Do the values match some Linux definitions, or are they arbitrary?

• hselasky accepted this revision.Mar 23 2021, 7:40 PM

This revision is now accepted and ready to land.Mar 23 2021, 7:40 PM

manu added a subscriber: manu.Mar 24 2021, 11:08 AM

manu added inline comments.

sys/compat/linuxkpi/common/include/linux/errno.h
61–62	They do not match linux definitions which could cause problems if they are expected to be returned to userland.

bz added inline comments.Mar 24 2021, 12:21 PM

sys/compat/linuxkpi/common/include/linux/errno.h
61–62	I'd assume (without looking) that none of the errnos in the 500s is matching Linux. Maybe we should add a comment if my assumption is correct? If they'd be returned to userland then it'd be a linux binary compat issue only I'd assume as native FreeBSD apps will normally never use those. In my case they currently should not be.

Add a comment above the block of error numbers above 500 to
document expectations as asked by @emaste and clarified by @manu .

This revision now requires review to proceed.Mar 24 2021, 7:12 PM

Harbormaster completed remote builds in B38056: Diff 86268.Mar 24 2021, 7:13 PM

bz marked 2 inline comments as done.Mar 24 2021, 7:13 PM

emaste accepted this revision.Mar 24 2021, 7:14 PM

This revision is now accepted and ready to land.Mar 24 2021, 7:14 PM

Closed by commit rG4b0632cfc5c8: LinuxKPI: add more linux-specific errno (authored by bz). · Explain WhyMar 24 2021, 10:42 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG4b0632cfc5c8: LinuxKPI: add more linux-specific errno.

bz added a commit: rG36d6711bd68f: LinuxKPI: add more linux-specific errno.Jul 18 2021, 12:36 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

2 lines

Diff 86207

sys/compat/linuxkpi/common/include/linux/errno.h

Loading...