makefs: Ignore the "tags" keyword
ClosedPublic
Actions

Authored by markj on Mar 23 2021, 2:25 AM.

Details

Reviewers

emaste
brooks
arichardson
imp

Commits

rGedda63ba979a: makefs: Ignore the "tags" keyword in mtree manifests
rGed42b22abc48: makefs: Ignore the "tags" keyword in mtree manifests

Summary

We emit these when making a filesystem using the METALOG that comes with
a -DNO_ROOT build. I believe they're used exclusively for pkgbase,
though I can't quite see how.

When building a filesystem using such a METALOG, many warnings get
emitted. It seems to make sense to just ignore this keyword (beyond
checking that there's an associated value).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mar 23 2021, 2:25 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 23 2021, 2:25 AM

markj requested review of this revision.Mar 23 2021, 2:25 AM

Harbormaster completed remote builds in B37999: Diff 86175.Mar 23 2021, 2:25 AM

markj added reviewers: emaste, brooks, arichardson.Mar 23 2021, 2:25 AM

imp accepted this revision.Mar 23 2021, 2:26 AM

This revision is now accepted and ready to land.Mar 23 2021, 2:26 AM

I don't see many reports of this on the mailing lists, so I might be doing something wrong. But I get tons of warnings with a simple

$ make installkernel -DNO_ROOT DESTDIR=/tmp
$ makefs ... /tmp/kernelfs.raw /tmp/METALOG

Seems sensible to me. I'm not entirely sure we shouldn't just silently ignore unknown tags unless some sort of --picky option is specified.

In D29384#658384, @brooks wrote:

Seems sensible to me. I'm not entirely sure we shouldn't just silently ignore unknown tags unless some sort of --picky option is specified.

I thought about it but wanted to stay conservative for now. The set of tools in the base system that emit or consume mtrees is fairly small so it's easy to evaluate keywords on a case-by-case basis.

Closed by commit rGed42b22abc48: makefs: Ignore the "tags" keyword in mtree manifests (authored by markj). · Explain WhyMar 23 2021, 6:38 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGed42b22abc48: makefs: Ignore the "tags" keyword in mtree manifests.

markj added a commit: rGedda63ba979a: makefs: Ignore the "tags" keyword in mtree manifests.Apr 6 2021, 1:08 PM