Page MenuHomeFreeBSD

Tune DTrace 'aframes' for the FBT and profile providers on arm64.
ClosedPublic

Authored by rwatson on Mar 21 2021, 12:08 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 11:16 PM
Unknown Object (File)
Tue, Oct 22, 11:16 PM
Unknown Object (File)
Tue, Oct 22, 11:16 PM
Unknown Object (File)
Tue, Oct 22, 10:55 PM
Unknown Object (File)
Oct 8 2024, 10:52 PM
Unknown Object (File)
Sep 22 2024, 11:34 PM
Unknown Object (File)
Sep 13 2024, 6:58 AM
Unknown Object (File)
Sep 8 2024, 7:35 AM

Details

Summary

In both cases, too few frames were trimmed, leading to exception handling
or DTrace internals being exposed in stack traces exposed by D's stack()
primitive.

MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 22 2021, 9:30 AM
emaste added inline comments.
sys/cddl/dev/profile/profile.c
107

I deleted this and the sparc comment above in 64a790d264808116469914c19265e905b3929e00, thinking that this change had already been committed. In any case this shouldn't be a conflict.

This revision now requires review to proceed.Mar 22 2021, 2:31 PM
andrew added inline comments.
sys/cddl/dev/profile/profile.c
117

There is also a duplicate __mips that could be removed after this has been committed

133

Here

This revision is now accepted and ready to land.Mar 22 2021, 2:58 PM