Page MenuHomeFreeBSD
Differential D29171

bsd.lib.mk: Add a install target for .pc files
ClosedPublic
Actions

Authored by manu on Mar 9 2021, 8:47 PM.
Tags
None
Referenced Files
F102392961: D29171.id85438.diff
Mon, Nov 11, 3:51 PM
Unknown Object (File)
Mon, Nov 4, 4:49 AM
Unknown Object (File)
Sep 30 2024, 5:05 AM
Unknown Object (File)
Sep 15 2024, 1:38 PM
Unknown Object (File)
Sep 12 2024, 1:40 AM
Unknown Object (File)
Sep 7 2024, 4:14 PM
Unknown Object (File)
Aug 17 2024, 10:54 PM
Unknown Object (File)
Aug 15 2024, 3:51 PM
View All 85 Files
Subscribers
bapt
bdrewery
emaste
freebsd_igalic.co
imp

Details

Reviewers
emaste
bapt
Group Reviewers
pkgbase
Commits
rG8c80fd34167c: bsd.lib.mk: Add a install target for .pc files
rG8a84b3736be1: bsd.lib.mk: Add a install target for .pc files
Summary

That way the files are correctly taggued for pkgbase

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

manu created this revision.Mar 9 2021, 8:47 PM
Herald added subscribers: emaste, imp, bdrewery. · View Herald TranscriptMar 9 2021, 8:47 PM
manu requested review of this revision.Mar 9 2021, 8:47 PM
Harbormaster completed remote builds in B37717: Diff 85438.Mar 9 2021, 8:47 PM
manu added a parent revision: D29170: include: Tag directly the last headers.Mar 9 2021, 8:47 PM
manu added a child revision: D29172: Convert libs with pc files to use PCFILES.
emaste accepted this revision.Mar 9 2021, 9:03 PM
emaste added inline comments.
share/mk/bsd.lib.mk
452

should we have a .PHONY?

This revision is now accepted and ready to land.Mar 9 2021, 9:03 PM
manu added inline comments.Mar 9 2021, 9:07 PM
share/mk/bsd.lib.mk
452

I don't think that it's needed, we don't do it for other installlib etc ...

emaste added inline comments.Mar 9 2021, 9:48 PM
share/mk/bsd.lib.mk
452

It will be functional without it indeed, but we would get strange behaviour if we ever end up with a file named as one of these targets for some reason.

manu added inline comments.Mar 10 2021, 9:06 AM
share/mk/bsd.lib.mk
452

Ok, I'll change the
.else
installpcfiles:
.endif
to
installpcfiles: .PHONY

and test, I think that will do the job.

bapt accepted this revision.Mar 11 2021, 5:30 AM
bapt added a subscriber: bapt.

beside the .PHONY thing as stated by @emaste LGTM

manu updated this revision to Diff 85566.Mar 11 2021, 12:38 PM

Add .PHONY to installpcfiles target.

This revision now requires review to proceed.Mar 11 2021, 12:38 PM
freebsd_igalic.co added a subscriber: freebsd_igalic.co.Mar 11 2021, 12:47 PM

🙋🏻‍♀️

share/mk/bsd.lib.mk
461

i believe we need an .else here, or else we'll have this target twice, and one of them will be .PHONY

manu added inline comments.Mar 11 2021, 2:25 PM
share/mk/bsd.lib.mk
461

AFAIK this will just either:

  • Create a new empty target with .PHONY attributes if PCFILES isn't defined
  • Set the .PHONY attribute to the already existing target if PCFILES is defined.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 16 2021, 6:14 AM
Closed by commit rG8a84b3736be1: bsd.lib.mk: Add a install target for .pc files (authored by manu). · Explain Why
This revision was automatically updated to reflect the committed changes.
manu added a commit: rG8a84b3736be1: bsd.lib.mk: Add a install target for .pc files.
manu added a commit: rG8c80fd34167c: bsd.lib.mk: Add a install target for .pc files.Jun 30 2021, 7:26 AM

Revision Contents
Changeset List

PathSize
share/
mk/
14 lines

Diff 85820

View Options

share/mk/bsd.lib.mk

Loading...