Page MenuHomeFreeBSD
Differential D29104

domainset: Define additional global policies
ClosedPublic
Actions

Authored by markj on Mar 5 2021, 10:51 PM.
Tags
None
Referenced Files
F97266440: D29104.diff
Sat, Sep 28, 9:30 AM
Unknown Object (File)
Mon, Sep 16, 7:02 AM
Unknown Object (File)
Mon, Sep 9, 5:54 PM
Unknown Object (File)
Wed, Sep 4, 11:36 AM
Unknown Object (File)
Sun, Sep 1, 2:51 AM
Unknown Object (File)
Sun, Sep 1, 12:05 AM
Unknown Object (File)
Sat, Aug 31, 12:44 PM
Unknown Object (File)
Sat, Aug 31, 5:48 AM
View All 65 Files
Subscribers
allanjude
gbe
imp
mav

Details

Reviewers
mav
Group Reviewers
manpages
Commits
rGbbf46d33a668: domainset: Define additional global policies
rG29bb6c19f044: domainset: Define additional global policies
Summary

Add global definitions for first-touch and interleave policies. The
former will be used in UMA.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 38261
Build 35150: arc lint + arc unit

Event Timeline

markj created this revision.Mar 5 2021, 10:51 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 5 2021, 10:51 PM
markj requested review of this revision.Mar 5 2021, 10:51 PM
markj added a child revision: D29105: uma: Implement a non-strict first-touch policy for slab allocation.
Harbormaster completed remote builds in B37631: Diff 85248.Mar 5 2021, 10:52 PM
allanjude added a subscriber: allanjude.Apr 1 2021, 7:26 PM
allanjude added inline comments.
sys/sys/domainset.h
106

Don't we need:

#define DOMAINSET_IL()		 (&domainset_interleave)

as well?

markj updated this revision to Diff 86709.Apr 1 2021, 8:13 PM
  • Add DOMAINSET_IL()
  • Update domainset.9
Herald added a reviewer: manpages. · View Herald TranscriptApr 1 2021, 8:13 PM
Harbormaster completed remote builds in B38261: Diff 86709.Apr 1 2021, 8:13 PM
gbe accepted this revision as: manpages.Apr 5 2021, 10:41 AM
gbe added a subscriber: gbe.

LGTM for the man page parts.

markj mentioned this in D29105: uma: Implement a non-strict first-touch policy for slab allocation.Apr 8 2021, 6:44 PM
mav added a subscriber: mav.Apr 8 2021, 7:16 PM
mav added inline comments.
sys/kern/kern_cpuset.c
1626

Shouldn't cpuset_zero always match domainset0 without having custom knowledge that DOMAINSET_FT() is the default now?

sys/sys/domainset.h
98

There should also be domainset_interleave declaration.

markj marked 2 inline comments as done.Apr 8 2021, 8:43 PM
markj added inline comments.
sys/kern/kern_cpuset.c
1626

Thanks, yes, it was an oversight.

markj updated this revision to Diff 87074.Apr 8 2021, 9:07 PM
markj marked an inline comment as done.

Address feedback.

Harbormaster completed remote builds in B38435: Diff 87074.Apr 8 2021, 9:07 PM
mav accepted this revision.Apr 8 2021, 9:10 PM
This revision is now accepted and ready to land.Apr 8 2021, 9:10 PM
Closed by commit rG29bb6c19f044: domainset: Define additional global policies (authored by markj). · Explain WhyApr 14 2021, 5:04 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG29bb6c19f044: domainset: Define additional global policies.
markj added a commit: rGbbf46d33a668: domainset: Define additional global policies.Apr 28 2021, 2:10 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
20 lines
sys/
kern/
38 lines
sys/
3 lines

Diff 86709

View Options

share/man/man9/domainset.9

Loading...
View Options

sys/kern/kern_cpuset.c

Loading...
View Options

sys/sys/domainset.h

Loading...