Page MenuHomeFreeBSD

efifb,vbefb: implement vd_fini
ClosedPublic

Authored by val_packett.cool on Mar 2 2021, 9:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Nov 10, 1:18 AM
Unknown Object (File)
Sun, Nov 10, 12:46 AM
Unknown Object (File)
Sat, Nov 9, 1:53 PM
Unknown Object (File)
Sat, Nov 9, 12:18 PM
Unknown Object (File)
Sat, Nov 9, 9:23 AM
Unknown Object (File)
Sat, Nov 9, 4:53 AM
Unknown Object (File)
Thu, Oct 17, 6:18 PM
Unknown Object (File)
Oct 5 2024, 8:50 AM

Details

Summary

This removes the pmap entry when switching away to e.g. drm fb.


Not strictly necessary to remove the mapping — avoiding conflicts (https://github.com/freebsd/drm-kmod/issues/60) is about avoiding *touching* the memory — but it's still nice to clean up.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37514
Build 34403: arc lint + arc unit

Event Timeline

You want to add the same to vbefb.

This revision is now accepted and ready to land.Mar 3 2021, 7:16 AM
val_packett.cool retitled this revision from efifb: implement vd_fini to efifb,vbefb: implement vd_fini.
val_packett.cool edited the summary of this revision. (Show Details)

Added vbefb (not tested)

This revision now requires review to proceed.Mar 9 2021, 12:35 PM
This revision is now accepted and ready to land.Mar 9 2021, 12:38 PM

@tsoome will you commit?

I planned to do it last weekend but this was delayed for this week. I'll probably do that tomorow.

In D29020#655703, @manu wrote:

@tsoome will you commit?

I planned to do it last weekend but this was delayed for this week. I'll probably do that tomorow.

ACK.

pstef added inline comments.
sys/dev/vt/hw/efifb/efifb.c
154

style nit: double space

sys/dev/vt/hw/vbefb/vbefb.c
160 ↗(On Diff #85386)

style nit: double space

This revision was automatically updated to reflect the committed changes.