mvebu_gpio: do not force data in value invertion during attach
AbandonedPublic
Actions

Authored by mw on Feb 24 2021, 2:56 PM.

Details

Reviewers

mmel
manu
kd

Summary

According to description of the Data In Polarity register,
configuring pin's corresponding bit to '1' inverts the
value its input. Hitherto configuration during attach
unconditionally set the invertion for each GPIO pin.
Fix that.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kd created this revision.Feb 24 2021, 2:56 PM

Herald added subscribers: loos, andrew. · View Herald TranscriptFeb 24 2021, 2:56 PM

kd requested review of this revision.Feb 24 2021, 2:56 PM

kd added a child revision: D28850: arm64: Fix spi_ranges_cnt in mv_ap806_gicp.

mw added a reviewer: manu.Feb 24 2021, 3:33 PM

Can you please try the test again with https://cgit.FreeBSD.org/src/commit/?id=ce5a4083de2d79bc44d209c9e355a09ede47346c ? I hope that it fixed also this problem. Thanks.

In D28911#649159, @mmel wrote:

Can you please try the test again with https://cgit.FreeBSD.org/src/commit/?id=ce5a4083de2d79bc44d209c9e355a09ede47346c ? I hope that it fixed also this problem. Thanks.

The fix does not help for observed issue. I get almost 100% hang rate on PCIE init on McBin when booting with DT from U-Boot and EDK2.
It will boot further 100% times with the GPIO driver probe disabled. I'll update this patch and add another GPIO driver fix - with those McBin passed 100x boot loop test.

PCIE hang example of pure today's HEAD:
https://gist.github.com/semihalf-wojtas-marcin/fd8ac0059aab12299b0d174aca5eaed6

Boot with the GPIO fixes (this patch + https://reviews.freebsd.org/D29013). Note, there are no ICU update, hence CP110 MMC timeout:
https://gist.github.com/semihalf-wojtas-marcin/04c1283b8b381760f8ad11b656c5d918

mw commandeered this revision.Mar 2 2021, 4:04 PM

mw edited reviewers, added: kd; removed: mw.

Testing showed, more changes are needed compared to v1. Now the pin configuration can be done only on purpose (which aligns the behavior to Linux).

mw retitled this revision from mvebu_gpio: Do not set input data polarity for every pin during attach. to mvebu_gpio: do not reconfigure every pin during attach.Mar 2 2021, 4:08 PM

mw edited the summary of this revision. (Show Details)

mw added a parent revision: D29013: mvebu_gpio: fix interrupt cause register configuration.Mar 2 2021, 4:10 PM

mw updated this revision to Diff 85066.Mar 3 2021, 6:36 PM

mw edited the summary of this revision. (Show Details)

mw edited parent revisions, added: D29044: mvebu_gpio: fix gpio pin configuration update; removed: D29013: mvebu_gpio: fix interrupt cause register configuration.

I don't think this change is necessary (it mitigates another bug). So I prefer to unconditionally initialize both registers in attach.

In D28911#650354, @mmel wrote:

I don't think this change is necessary (it mitigates another bug). So I prefer to unconditionally initialize both registers in attach.

I can agree for blink register, but inverting data in polarity for each pin is imo not good idea. I'll update the patch.

mw updated this revision to Diff 85078.Mar 3 2021, 9:45 PM

mw retitled this revision from mvebu_gpio: do not reconfigure every pin during attach to mvebu_gpio: do not force data in value invertion during attach.

mw edited the summary of this revision. (Show Details)

mmel mentioned this in rGa5dce53b75d8: mvebu_gpio: Multiple fixes..Mar 4 2021, 4:55 PM

mw abandoned this revision.May 27 2021, 6:51 AM

mmel mentioned this in rG9ddb35ef1fd2: mvebu_gpio: Multiple fixes..Jan 20 2022, 10:24 AM