Page MenuHomeFreeBSD
Differential D28900

iflib: Avoid double counting in rxeof
ClosedPublic
Actions

Authored by markj on Feb 23 2021, 3:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 6:14 AM
Unknown Object (File)
Wed, Jan 22, 11:28 AM
Unknown Object (File)
Sat, Jan 18, 5:47 PM
Unknown Object (File)
Fri, Jan 10, 2:03 AM
Unknown Object (File)
Dec 11 2024, 1:01 PM
Unknown Object (File)
Dec 7 2024, 8:21 PM
Unknown Object (File)
Nov 24 2024, 9:05 PM
Unknown Object (File)
Nov 24 2024, 4:21 AM
View All 66 Files
Subscribers
ae
erj
imp
melifaro

Details

Reviewers
shurd
gallatin
erj
Group Reviewers
iflib
Commits
rG18b6283014a2: iflib: Avoid double counting in rxeof
rG76294b65df64: iflib: Avoid double counting in rxeof
rGb6999635b195: iflib: Avoid double counting in rxeof
Summary

iflib_rxeof() was counting everything twice. This was introduced when
pfil hooks were added to iflib. I believe we want to count rx
packets/bytes before the pfil hooks are executed, so remove the counter
adjustments that are executed after.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 37317
Build 34206: arc lint + arc unit

Event Timeline

markj created this revision.Feb 23 2021, 3:51 PM
Herald added a reviewer: shurd. · View Herald TranscriptFeb 23 2021, 3:51 PM
Herald added a reviewer: iflib. · View Herald Transcript
Herald added subscribers: melifaro, ae, imp. · View Herald Transcript
markj requested review of this revision.Feb 23 2021, 3:51 PM
Harbormaster completed remote builds in B37317: Diff 84556.Feb 23 2021, 3:51 PM
markj added a reviewer: gallatin.Feb 23 2021, 3:51 PM
erj added a subscriber: erj.Feb 23 2021, 5:43 PM
erj added inline comments.
sys/net/iflib.c
2926–2927

So then, this is the one place that the stats should be incremented

markj added inline comments.Feb 23 2021, 5:47 PM
sys/net/iflib.c
2926–2927

Correct. The deleted lines run after pfil hooks run, and so won't count dropped (recycled) packets.

gallatin accepted this revision.Feb 23 2021, 8:16 PM
This revision is now accepted and ready to land.Feb 23 2021, 8:16 PM
erj accepted this revision.Feb 23 2021, 10:43 PM
Closed by commit rGb6999635b195: iflib: Avoid double counting in rxeof (authored by markj). · Explain WhyFeb 24 2021, 3:13 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGb6999635b195: iflib: Avoid double counting in rxeof.
markj added a commit: rG76294b65df64: iflib: Avoid double counting in rxeof.Feb 27 2021, 4:09 PM
markj added a commit: rG18b6283014a2: iflib: Avoid double counting in rxeof.Feb 28 2021, 8:51 PM

Revision Contents
Changeset List

PathSize
sys/
net/
2 lines

Diff 84556

View Options

sys/net/iflib.c

Loading...