Page MenuHomeFreeBSD
Differential D28881

release(7): Remove stray references to DOC* variables
ClosedPublic
Actions

Authored by debdrup on Feb 23 2021, 8:33 AM.
Tags
None
Referenced Files
F102430941: D28881.diff
Tue, Nov 12, 4:29 AM
Unknown Object (File)
Mon, Oct 28, 10:13 PM
Unknown Object (File)
Mon, Oct 28, 10:13 PM
Unknown Object (File)
Mon, Oct 28, 10:12 PM
Unknown Object (File)
Mon, Oct 28, 10:12 PM
Unknown Object (File)
Mon, Oct 28, 10:12 PM
Unknown Object (File)
Mon, Oct 28, 10:12 PM
Unknown Object (File)
Mon, Oct 28, 9:56 PM
View All Files
Subscribers
imp
lwhsu
yuripv

Details

Reviewers
gjb
0mp
Group Reviewers
manpages
Commits
rGf695e960672d: release(7): Remove stray references to DOC* variables
Summary

We now live in the world of git, and release(7) should reflect that.

As of the commit referenced below, release images also no longer
include (stale) documentation, as the documentation has moved to
AsciiDoctor. This means that a few environment variables no longer
make sense, so remove them from their sections and mention them in
the compatibility section instead.

While here, also pet mandoc.

PR: 253615
MFC after: 3 days
MFC with: f61e92ca5a23 release: permanently remove the 'reldoc'
target and associates

Test Plan

Igor, mandoc, and mantra.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

debdrup created this revision.Feb 23 2021, 8:33 AM
Herald added a reviewer: manpages. · View Herald TranscriptFeb 23 2021, 8:33 AM
Herald added a subscriber: imp. · View Herald Transcript
debdrup requested review of this revision.Feb 23 2021, 8:33 AM
Harbormaster completed remote builds in B37295: Diff 84518.Feb 23 2021, 8:34 AM
debdrup edited the test plan for this revision. (Show Details)Feb 23 2021, 8:34 AM
lwhsu added a subscriber: lwhsu.Feb 23 2021, 12:26 PM
lwhsu added inline comments.
share/man/man7/release.7
674

I suggest using the output of git rev-parse --short, which will detect how long the short hash is enough. So f61e92ca5a23.

yuripv added a subscriber: yuripv.Feb 23 2021, 2:01 PM
yuripv added inline comments.
share/man/man7/release.7
682–683

bad sort order

debdrup updated this revision to Diff 84547.EditedFeb 23 2021, 2:41 PM
debdrup marked 2 inline comments as done.

Address feedback by @lwhsu and @yuripv

Harbormaster completed remote builds in B37309: Diff 84547.Feb 23 2021, 2:42 PM
debdrup updated this revision to Diff 84548.EditedFeb 23 2021, 2:43 PM

Address feedback by @yuripv on IRC.

Harbormaster completed remote builds in B37310: Diff 84548.Feb 23 2021, 2:44 PM
lwhsu added inline comments.Feb 23 2021, 3:49 PM
share/man/man7/release.7
674

The hash length is still 8, what src repo uses is 12.

debdrup updated this revision to Diff 84559.Feb 23 2021, 4:39 PM

This time actually correct the hash length, pointed out by @lwhsu

Harbormaster completed remote builds in B37320: Diff 84559.Feb 23 2021, 4:39 PM
debdrup marked an inline comment as done.Feb 23 2021, 4:39 PM
gjb accepted this revision.Feb 23 2021, 5:15 PM
gjb added inline comments.
share/man/man7/release.7
616

This should reference '-b main', as the svn equivalent would checkout from head as written.

This revision is now accepted and ready to land.Feb 23 2021, 5:15 PM
Closed by commit rGf695e960672d: release(7): Remove stray references to DOC* variables (authored by debdrup). · Explain WhyFeb 23 2021, 6:08 PM
This revision was automatically updated to reflect the committed changes.
debdrup added a commit: rGf695e960672d: release(7): Remove stray references to DOC* variables.
debdrup mentioned this in D28905: committers-guide: update commit trailer descriptions.Feb 23 2021, 7:44 PM

Revision Contents
Changeset List

PathSize
share/
man/
man7/
72 lines

Diff 84571

View Options

share/man/man7/release.7

Loading...