Page MenuHomeFreeBSD

bhyve/snapshot: rename and bump size of MAX_SNAPSHOT_VMNAME
ClosedPublic

Authored by rew on Feb 23 2021, 1:50 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 4:16 PM
Unknown Object (File)
Sun, Oct 20, 11:52 PM
Unknown Object (File)
Sun, Oct 20, 11:52 PM
Unknown Object (File)
Sun, Oct 20, 11:52 PM
Unknown Object (File)
Sun, Oct 20, 11:37 PM
Unknown Object (File)
Oct 3 2024, 9:20 AM
Unknown Object (File)
Oct 2 2024, 11:54 PM
Unknown Object (File)
Oct 2 2024, 8:36 PM

Details

Summary

MAX_SNAPSHOT_VMNAME is a macro used to set the size of a character
buffer that stores a filename or the path to a file. I suggest
renaming this macro to MAX_SNAPSHOT_FILENAME instead.

Since MAX_SNAPSHOT_FILENAME is used to store a filename, NAME_MAX is
probably a better value. I thought about PATH_MAX, as it may be more
appropriate, but I chose the more conservative value of the two, so
NAME_MAX.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rew requested review of this revision.Feb 23 2021, 1:50 AM
jhb added a subscriber: jhb.

I would probably use PATH_MAX. Another option is that once this socket is a datagram socket, this could become a variable length packet with a VLA for the filename instead of a fixed size buffer.

This revision is now accepted and ready to land.Feb 25 2021, 7:25 PM