tcp_lro_log: mark __unused to avoid unused function warning

[rlibby]

Summary

After ab4fad4be14462e347ed24ee3663a18eacfb138e tcp_lro_log became only
used if TCPHPTS was defined. Annotate it with __unused to suppress a
warning from gcc.

Test Plan

env MAKEOBJDIRPREFIX=/usr/obj/gcc9 CROSS_TOOLCHAIN=amd64-gcc9 make buildkernel

[rrs]

question

If we put the wrap
#ifdef TCPHPTS

#endif

Around the function do we still need __unused for gcc?

(it won't be unused of course if TCPHPTS is defined)

[rlibby]

In D28761#644041, @rrs wrote:

question

If we put the wrap
#ifdef TCPHPTS

#endif

Around the function do we still need __unused for gcc?

(it won't be unused of course if TCPHPTS is defined)

Right, that would work too. Is that your preference?

My thought was that it wasn't clear to me that tcp_lro_log was really related to TCPHPTS. If other tcp_lro code wanted to call it, would it then have to change the ifdef? But I will defer to your judgement there.

[rlibby]

Dropping, alternate solution committed as 0a4f851074a3ca74cd4859c20e7d9807b2aeca65.

[rscheff]

I prefer the traditional approach taken in D28759.