Page MenuHomeFreeBSD
Differential D28604

ofwfb: fix incorrect colors on powerpc*, add new tunable parameters
ClosedPublic
Actions

Authored by alfredo on Feb 12 2021, 12:48 AM.
Tags
Referenced Files
Unknown Object (File)
Tue, Nov 5, 11:40 AM
Unknown Object (File)
Mon, Nov 4, 1:57 AM
Unknown Object (File)
Mon, Nov 4, 1:55 AM
Unknown Object (File)
Mon, Nov 4, 1:54 AM
Unknown Object (File)
Mon, Nov 4, 1:53 AM
Unknown Object (File)
Mon, Nov 4, 1:34 AM
Unknown Object (File)
Fri, Nov 1, 10:32 PM
Unknown Object (File)
Tue, Oct 29, 4:31 AM
View All Files
Subscribers
bdragon
imp
luporl

Details

Reviewers
bdragon
luporl
Group Reviewers
PowerPC
ARM
MIPS
Commits
rG07656628fdbc: ofwfb: fix incorrect colors on powerpc* and add new tunable parameters
rGa78bb831a17f: fbio: Use appropriate types for the physical and virtual framebuffer address
rG50b7c1f530f1: ofwfb: fix incorrect colors on powerpc* and add new tunable parameters
Summary
  • Implements little-endian support (powerpc64le)
  • Adds 'hw.ofwfb.physaddr' kernel parameter so user can manually provide correct address if it's not detected correctly
  • Adds 'hw.ofwfb.argb32_pixel' so user can set it manually if colors are inverted due to incorrect pixel format (default value is 1)
  • Automatically selects RGBA32 pixel format if NVidia graphic adapter is detected (sets hw.ofwfb.argb32_pixel=0)

During tests it was observed that machines equipped with NVidia graphic adapters tend to use RGBA32 pixel format. By default ARGB32 pixel format is used, proved to work on machines equipped with ATI graphic adapter and the onboard adapter used on Talos II and Blackbird machines from Raptor Computing Systems.

*Patch taken originally from @bdragon with small modifications

It looks like ofwfb is only used on powerpc world. Adding ARM and MIPS teams as reviewers due to changes in sys/sys/fbio.h

Test Plan

runtime test on:

  • QEMU (powerpc64, using vnc)
  • PowerBook5,6 (powerpc 32 bits G4)

build test on:

  • powerpc64/powerpc
  • powerpc64le/powerpc
  • powerpc/powerpc
  • powerpcspe/powerpc
  • aarch64/arm64
  • amd64/amd64

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alfredo created this revision.Feb 12 2021, 12:48 AM
Herald added subscribers: luporl, imp. · View Herald TranscriptFeb 12 2021, 12:48 AM
alfredo requested review of this revision.Feb 12 2021, 12:48 AM
Harbormaster completed remote builds in B36917: Diff 83729.Feb 12 2021, 12:48 AM
bdragon added a comment.Feb 12 2021, 4:59 AM

Confirmed correct on an nvidia-based powerbook g4.

Also, double checked on an ATI-based powerbook g4 for comparison.

(BTW, for those testing - running "vidcontrol show" is the best way to verify that the pixel format is 100% correct, as it lets you verify the 16-color palette against the color names.)

The fbio.h change will need build-tested for universe kernels.

luporl added a comment.Feb 12 2021, 12:44 PM

Looks good. I have been using a slightly modified version of this on Talos II and it is working well.

sys/dev/vt/hw/ofwfb/ofwfb.c
429

Does this work on LE?
Or does OF_getencprop need to be used instead?

475–480

This fails to compile on LE, due to missing braces.

alfredo updated this revision to Diff 83759.Feb 12 2021, 2:38 PM
alfredo edited the test plan for this revision. (Show Details)

fix missing braces on powerpc64le

powerpc64, powerpc64le, amd64, aarch64

Harbormaster completed remote builds in B36928: Diff 83759.Feb 12 2021, 2:38 PM
alfredo marked 2 inline comments as done.Feb 12 2021, 2:40 PM
In D28604#640374, @bdragon wrote:

Also, double checked on an ATI-based powerbook g4 for comparison.

Tested on PowerBook G4 ATI-based with succes (PowerBook5.6 -model A1106)

The fbio.h change will need build-tested for universe kernels.

sys/dev/vt/hw/ofwfb/ofwfb.c
429

Good catch, thanks!
If possible, please try this latest version as base for your patches, on powerpc64le

alfredo edited the summary of this revision. (Show Details)Feb 12 2021, 3:06 PM
alfredo added reviewers: ARM, MIPS.
bdragon added a comment.Feb 15 2021, 3:21 PM

Universe build went fine.

bdragon accepted this revision.Feb 18 2021, 9:59 PM

Should be good for HEAD.

However, the fbio change should be tested on i386 PAE to make sure it doesn't cause binary incompatibility. If it does, we won't be able to MFC it as is.

This revision is now accepted and ready to land.Feb 18 2021, 9:59 PM
alfredo marked an inline comment as done.Feb 19 2021, 2:14 AM
In D28604#644428, @bdragon wrote:

Should be good for HEAD.

However, the fbio change should be tested on i386 PAE to make sure it doesn't cause binary incompatibility. If it does, we won't be able to MFC it as is.

Thanks! As we discussed on IRC, I'm going to split this patch in two commits so ofwfb.c can be MFCed to stable/13 to avoid the risk of ABI break on other platforms using fbio.h

luporl accepted this revision.Feb 19 2021, 12:02 PM

Worked fine on PPC64LE, both on Talos and QEMU, with D27475 to fix boot with ofwfb on LE.

Closed by commit rG50b7c1f530f1: ofwfb: fix incorrect colors on powerpc* and add new tunable parameters (authored by alfredo). · Explain WhyFeb 19 2021, 7:54 PM
This revision was automatically updated to reflect the committed changes.
alfredo added a commit: rG50b7c1f530f1: ofwfb: fix incorrect colors on powerpc* and add new tunable parameters.
alfredo added a commit: rGa78bb831a17f: fbio: Use appropriate types for the physical and virtual framebuffer address.Feb 19 2021, 8:56 PM
alfredo added a commit: rG07656628fdbc: ofwfb: fix incorrect colors on powerpc* and add new tunable parameters.Feb 23 2021, 9:09 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
hw/
ofwfb/
165 lines

Diff 84291

View Options

sys/dev/vt/hw/ofwfb/ofwfb.c

Loading...