Differential D28388

close_range: add audit support
ClosedPublic
Actions

Authored by arichardson on Jan 28 2021, 9:38 AM.

Tags

None

Referenced Files

	F108439102: D28388.id84569.diff
	Fri, Jan 24, 7:03 PM

	Unknown Object (File)
	Tue, Jan 21, 9:07 AM

	Unknown Object (File)
	Fri, Jan 17, 1:05 PM

	Unknown Object (File)
	Thu, Dec 26, 11:12 PM

	Unknown Object (File)
	Dec 25 2024, 11:33 PM

	Unknown Object (File)
	Dec 25 2024, 1:37 PM

	Unknown Object (File)
	Dec 24 2024, 1:38 AM

	Unknown Object (File)
	Nov 30 2024, 3:43 AM

View All 82 Files

Subscribers

Details

Reviewers

kevans
csjp

Group Reviewers

Commits

rG6805e948c4ce: close_range: add audit support
rGfa32350347b4: close_range: add audit support

Summary

This fixes the closefrom test in sys/audit.

Includes cherry-picks of the following commits from openbsm:

https://github.com/openbsm/openbsm/commit/4dfc628aafe589d68848f7033f3d3488c4d979e0
https://github.com/openbsm/openbsm/commit/99ff6fe32aebc5a4b8d40d60062b8574697df557
https://github.com/openbsm/openbsm/commit/da48a0399e95448693d3fa2be48454ca564c1be8

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36561
Build 33450: arc lint + arc unit

Event Timeline

arichardson created this revision.Jan 28 2021, 9:38 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 28 2021, 9:38 AM

arichardson requested review of this revision.Jan 28 2021, 9:38 AM

Harbormaster completed remote builds in B36561: Diff 83026.Jan 28 2021, 9:38 AM

The contrib update should probably be a vendor import instead of part of this commit, but I've included in the revision to make it obvious what needs to change.

Ah, damn, I had staged this in D24553 but failed to follow through. I like cmd better, though, since hifd will most often not be a valid fd. I'll take a closer look in a bit

kevans accepted this revision.Jan 29 2021, 1:27 AM

This revision is now accepted and ready to land.Jan 29 2021, 1:27 AM

@kevans should I do the openbsm vendor update or will you do it?

In D28388#635536, @arichardson wrote:

@kevans should I do the openbsm vendor update or will you do it?

I think @gbe actually has it staged or nearly there, so I'll defer to him on that (and CC here for awareness)

arichardson mentioned this in D28451: tests/sys/audit: Avoid race caused by starting auditd(8) for testing.Feb 1 2021, 7:17 PM

arichardson mentioned this in rGdf093aa9463b: tests/sys/audit: Avoid race caused by starting auditd(8) for testing.Feb 18 2021, 2:04 PM

ping? Should I commit this as is or continue waiting for a contrib/openbsm update?

Closed by commit rGfa32350347b4: close_range: add audit support (authored by arichardson). · Explain WhyFeb 23 2021, 5:59 PM

This revision was automatically updated to reflect the committed changes.

arichardson added a commit: rGfa32350347b4: close_range: add audit support.

arichardson mentioned this in rGeb52de783a1c: tests/sys/audit: Avoid race caused by starting auditd(8) for testing.Mar 17 2021, 10:23 PM

arichardson added a commit: rG6805e948c4ce: close_range: add audit support.

Revision Contents
Changeset List

Path

Size

contrib/

openbsm/

etc/

2 lines

sys/

bsm/

audit_kevents.h

2 lines

sys/

kern/

4 lines

security/

audit/

15 lines

tests/

sys/

audit/

4 lines

Diff 83026

contrib/openbsm/etc/audit_event

Loading...

contrib/openbsm/sys/bsm/audit_kevents.h

Loading...

sys/kern/kern_descrip.c

Loading...

sys/security/audit/audit_bsm.c

Loading...

tests/sys/audit/file-close.c

Loading...