Page MenuHomeFreeBSD
Differential D28372

Add BUGS section about pwrite(2)
ClosedPublic
Actions

Authored by khng on Jan 27 2021, 4:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 11, 2:25 AM
Unknown Object (File)
Sep 30 2024, 9:18 AM
Unknown Object (File)
Sep 20 2024, 9:05 AM
Unknown Object (File)
Sep 7 2024, 9:42 PM
Unknown Object (File)
Sep 7 2024, 6:51 PM
Unknown Object (File)
Sep 5 2024, 3:28 AM
Unknown Object (File)
Sep 4 2024, 8:29 PM
Unknown Object (File)
Sep 2 2024, 1:56 PM
View All 79 Files
Subscribers
gbe
imp
ygy
yuripv
Contributor Reviews (src)

Details

Reviewers
lwhsu
emaste
ygy
Group Reviewers
manpages
Commits
rG1350f1ccc156: pwrite(2): add a BUGS section
rG115ea98aede3: pwrite(2): add a BUGS section
rG12c27808888b: pwrite(2): add a BUGS section
rG504e64af32ba: pwrite(2): add a BUGS section
Summary

Add a BUGS section about using pwrite(2) when O_APPEND
is set on the fd.

Submitted by: Ka Ho Ng
MFC after: 3 days

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

khng created this revision.Jan 27 2021, 4:45 PM
Herald added a reviewer: manpages. · View Herald TranscriptJan 27 2021, 4:45 PM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald Transcript
khng requested review of this revision.Jan 27 2021, 4:45 PM
Harbormaster completed remote builds in B36537: Diff 82982.Jan 27 2021, 4:45 PM
khng added reviewers: lwhsu, emaste.Jan 27 2021, 4:45 PM
khng updated this revision to Diff 82983.Jan 27 2021, 4:47 PM
  • Update wording
Harbormaster completed remote builds in B36538: Diff 82983.Jan 27 2021, 4:47 PM
khng edited the summary of this revision. (Show Details)Jan 27 2021, 4:48 PM
khng edited the summary of this revision. (Show Details)
gbe accepted this revision as: manpages.Jan 27 2021, 4:49 PM
gbe added a subscriber: gbe.

LGTM from the manpages perspective.

@emaste, if write(2) isn't working as specified by POSIX, the libc should maybe updated.

lwhsu added a comment.Feb 3 2021, 4:45 PM

@gbe : do we need to update .Dd field for this change?

ygy accepted this revision.Feb 11 2021, 1:59 PM
ygy added a subscriber: ygy.

LGTM on the doc side, please update .Dd when committing, thanks ;)

This revision is now accepted and ready to land.Feb 11 2021, 1:59 PM
yuripv added a subscriber: yuripv.Feb 11 2021, 2:01 PM
yuripv added inline comments.
lib/libc/sys/write.2
306–307

nitpicking: this could be one line

khng updated this revision to Diff 83691.Feb 11 2021, 3:14 PM
  • Make "contrary to" one-line
This revision now requires review to proceed.Feb 11 2021, 3:14 PM
Harbormaster completed remote builds in B36892: Diff 83691.Feb 11 2021, 3:14 PM
khng marked an inline comment as done.Feb 11 2021, 3:14 PM
In D28372#637157, @lwhsu wrote:

@gbe : do we need to update .Dd field for this change?

Done.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 20 2021, 8:07 AM
Closed by commit rG504e64af32ba: pwrite(2): add a BUGS section (authored by ygy). · Explain Why
This revision was automatically updated to reflect the committed changes.
ygy added a commit: rG504e64af32ba: pwrite(2): add a BUGS section.
ygy added a commit: rG12c27808888b: pwrite(2): add a BUGS section.Feb 25 2021, 6:58 AM
ygy added a commit: rG115ea98aede3: pwrite(2): add a BUGS section.Feb 28 2021, 3:49 AM
ygy added a commit: rG1350f1ccc156: pwrite(2): add a BUGS section.Feb 28 2021, 4:21 AM

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
16 lines

Diff 84319

View Options

lib/libc/sys/write.2

Loading...