Page MenuHomeFreeBSD

[new port] : textproc/py-diff-match-patch
ClosedPublic

Authored by rene on Jun 15 2015, 10:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 21, 10:52 PM
Unknown Object (File)
Mon, Oct 21, 10:52 PM
Unknown Object (File)
Mon, Oct 21, 10:52 PM
Unknown Object (File)
Mon, Oct 21, 10:52 PM
Unknown Object (File)
Mon, Oct 21, 10:51 PM
Unknown Object (File)
Mon, Oct 21, 10:34 PM
Unknown Object (File)
Mon, Oct 21, 5:00 PM
Unknown Object (File)
Oct 5 2024, 5:09 AM
Subscribers

Details

Summary

The Diff Match and Patch libraries offer robust algorithms to perform
the operations required for synchronizing plain text.

Dependency for D1234

Test Plan

Completed poudriere testbuilds on 8,9,10 amd64/i386

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rene retitled this revision from to [new port] : textproc/py-diff-match-patch.
rene updated this object.
rene edited the test plan for this revision. (Show Details)
rene added a reviewer: Python.
koobs requested changes to this revision.Jun 22 2015, 6:02 AM
koobs added a reviewer: koobs.
koobs added a subscriber: koobs.
koobs added inline comments.
textproc/py-diff-match-patch/Makefile
6

:|

Might we want to maybe make this 0.0.0.{datestamp} to protect from having to add/bump PORTEPOCH in the future?

18

test_suite is set in setup.py which points to the module/class that implements the test. no tests_require means no additional dependencies are needed.

Can remove this comment when regression-test: target is implemented

20

shebangfix is likely not necessary (but certainly check).

setuptools normally 'converts' these to the python version that was used to build/install them if they are declared correctly (as console_scripts)

See:

https://pythonhosted.org/setuptools/setuptools.html#automatic-script-creation

This revision now requires changes to proceed.Jun 22 2015, 6:02 AM
rene edited edge metadata.
rene removed rP FreeBSD ports repository as the repository for this revision.

Changed PORTVERSION to start with 0.0.0

rene marked an inline comment as done.Jun 22 2015, 7:11 PM
rene added inline comments.
textproc/py-diff-match-patch/Makefile
18

There is a key test_suite in setup() in setup.py, can that somehow be invoked?

20

Somehow shebangfix is needed here, just look at the resulting files in the stage directory when not using it.

rene set the repository for this revision to rP FreeBSD ports repository.
rene added a child revision: D1234: textproc/pootle revival.

Diffs don't appear to be displaying correctly (or at all) in the reviews, so I cant accept what I can't see :)

I think it may be an ongoing phabric issue cc @eadler

textproc/py-diff-match-patch/Makefile
24

The canonical test invocation I use is:

regression-test: build
<tab>@cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test

That *should* work, and if not, should be patched so it does and fixes sent upstream

Added regression-test target, which works fine.

In case phabricator does not work, a full svn diff is available at https://people.freebsd.org/~rene/py-diff-match-patch.diff

koobs edited edge metadata.

Looks good @rene!

This revision is now accepted and ready to land.Jun 23 2015, 8:19 AM
This revision was automatically updated to reflect the committed changes.