Fix type errors.

[kib]

Summary

Target value for val has uint32_t type, not uint, adjust used constant.
Cast val to unsigned so that left and right sides of comparision operator do not expose different signed types of same range.

[emaste]

Will this give an is always false warning? Should we use strtoll instead

[kib]

Add header for UINT32_MAX.

[mjg]

This still breaks buildworld on several archs:

/usr/src/usr.bin/elfctl/elfctl.c:258:35: error: use of undeclared identifier 'UINT32_MAX'

else if ((unsigned long)val > UINT32_MAX)

adding stdint.h fixes it

huh, bad timing

[kib]

In D28301#633157, @emaste wrote:

Will this give an is always false warning? Should we use strtoll instead

For me, the build worked. Are you worried about gcc?

[emaste]

For me, the build worked. Are you worried about gcc?

Ah, yes I see it builds fine with this change, but e.g. 0xffffffff doesn't work on 32-bit with long.

[kib]

Switch to unsigned long long/strtoll