rtld: change a few const char* variables to bool
Needs ReviewPublic
Actions

Authored by arichardson on Jan 18 2021, 11:16 AM.

Details

Reviewers

kib
jhb
jrtc27
brooks

Summary

This simplifies their usage. This patch also adds a new helper function to
convert an environment variable to a boolean: all variables that are set,
non-empty, and not equal to "0" are treated as true.

Depends on D28220

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36313
Build 33202: arc lint + arc unit

Event Timeline

arichardson created this revision.Jan 18 2021, 11:16 AM

Herald added a subscriber: bdragon. · View Herald TranscriptJan 18 2021, 11:16 AM

Harbormaster completed remote builds in B36310: Diff 82455.Jan 18 2021, 11:16 AM

arichardson requested review of this revision.Jan 18 2021, 11:16 AM

style fix

Harbormaster completed remote builds in B36313: Diff 82458.Jan 18 2021, 11:37 AM

The documentation for these says "When set to a nonempty string", and the GNU world does the same (e.g. see LD_TRACE_LOADED_OBJECTS=1 /bin/echo on a GNU/Linux system), so the strcmp shouldn't be added.

In D28221#632160, @jrtc27 wrote:

The documentation for these says "When set to a nonempty string", and the GNU world does the same (e.g. see LD_TRACE_LOADED_OBJECTS=1 /bin/echo on a GNU/Linux system), so the strcmp shouldn't be added.

Sure, I can drop that, I just thought that enabling it by passing LD_TRACE_LOADED_OBJECTS=0 /bin/echo is a bit odd.

I'm fine with the cleanup, but agree with Jess that having the value set to non-empty is what should constitute "true".

Revision Contents
Changeset List

Path

Size

libexec/

rtld-elf/

rtld.c

66 lines

Diff 82458

View Options

rtld: change a few const char* variables to boolNeeds ReviewPublicActions