Page MenuHomeFreeBSD
Differential D28200

Set MAC to broadcast when pinging 255.255.255.255 as noted in RFC919
AcceptedPublic
Actions

Authored by antranigv_freebsd.am on Jan 16 2021, 10:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 25, 11:12 AM
Unknown Object (File)
Oct 8 2024, 10:25 PM
Unknown Object (File)
Oct 8 2024, 1:24 AM
Unknown Object (File)
Oct 6 2024, 12:28 AM
Unknown Object (File)
Oct 5 2024, 10:49 PM
Unknown Object (File)
Oct 3 2024, 7:54 AM
Unknown Object (File)
Oct 3 2024, 1:57 AM
Unknown Object (File)
Sep 30 2024, 10:33 AM
View All 45 Files
Subscribers
ae
imp
melifaro
rgrimes
Contributor Reviews (src)

Details

Reviewers
kp
melifaro
tuexen
bz
Group Reviewers
network
Summary

According to RFC919, when pinging 255.255.255.255 the MAC address should be set to broadcast (ffff ffff ffff).
Relates to Bug 252596 submitted by jcaplan

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 36283
Build 33172: arc lint + arc unit

Event Timeline

antranigv_freebsd.am created this revision.Jan 16 2021, 10:12 PM
Herald added subscribers: Contributor Reviews (src), melifaro, imp. · View Herald TranscriptJan 16 2021, 10:12 PM
Harbormaster completed remote builds in B36283: Diff 82391.Jan 16 2021, 10:12 PM
antranigv_freebsd.am requested review of this revision.Jan 16 2021, 10:12 PM
antranigv_freebsd.am added a reviewer: kp.Jan 16 2021, 10:13 PM
antranigv_freebsd.am retitled this revision from Set MAC to broadcast when pinging 255.255.255.255 to Set MAC to broadcast when pinging 255.255.255.255 as noted in RFC919.Jan 16 2021, 10:19 PM
antranigv_freebsd.am edited the summary of this revision. (Show Details)
antranigv_freebsd.am added a reviewer: network.
melifaro accepted this revision as: melifaro.Jan 16 2021, 10:47 PM
This revision is now accepted and ready to land.Jan 16 2021, 10:47 PM
kp accepted this revision as: kp.Jan 18 2021, 12:06 PM
ae added a subscriber: ae.Jan 18 2021, 1:54 PM

We already have IP_SENDONES flag for ip_output, that should serve for this purpose. Maybe is it not safe enough to allow this feature for all protocols?

ae added reviewers: tuexen, bz.Jan 18 2021, 1:55 PM
kp added a comment.Jan 21 2021, 11:59 AM
In D28200#630843, @ae wrote:

We already have IP_SENDONES flag for ip_output, that should serve for this purpose. Maybe is it not safe enough to allow this feature for all protocols?

I think that serves a different purpose. IP_SENDONES allows users to decide the packet should be broadcast, regardless of destination address. This change fixes an oversight, where we don't mark a packet as being broadcast (and thus send it to ethernet ff:ff:ff:ff:ff:ff) if it's sent to 255.255.255.255.

antranigv_freebsd.am added a comment.Sep 3 2021, 4:00 PM

@kp should we merge this or it's stale? :) Just reminding.

kp added a comment.Sep 18 2021, 2:07 PM

So, I've been looking at committing this, and I'm still convinced that the previous behaviour is indeed incorrect, but I'm no longer sure this is the correct fix.
We should probably call in_broadcast() to run this check, rather than duplicate the logic here.

rgrimes added a subscriber: rgrimes.Sep 18 2021, 5:00 PM
In D28200#722356, @kp wrote:

So, I've been looking at committing this, and I'm still convinced that the previous behaviour is indeed incorrect, but I'm no longer sure this is the correct fix.
We should probably call in_broadcast() to run this check, rather than duplicate the logic here.

Yes, please use in_broadcast() to do the check.

sys/netinet/ip_output.c
506

INADDR_ANY looks very wrong here, this would make 0.0.0.0 a broadcast address. Please see D31861 as we just fixed that in the general case.

Revision Contents
Changeset List

PathSize
sys/
netinet/
4 lines

Diff 82391

View Options

sys/netinet/ip_output.c

Loading...