bsdinstall: create /EFI/BOOT directory in ESP

[mhorne]

Summary

If the installer is creating a new ESP, then this directory will not
exist and the subsequent cp will fail silently. This is usually of no
consequence if /EFI/freebsd/loader.efi is set up correctly.

Test Plan

bsdinstall to a blank disk, verify that /EFI/BOOT/BOOT${arch}.EFI is present on the ESP.

[mhorne]

Ping. Any objection to this patch?

[imp]

The dirname got me thinking and that lead to these larger suggestions, as well as moving it earlier.

usr.sbin/bsdinstall/scripts/bootconfig

134–136

BOOTDIR="/efi/boot"
BOOTNAME="${BOOTDIR}/boot${ARCHBOOTNAME}.efi
FREEBSD_BOOTDIR="/efi/freebsd"

152–153

mkdir -p "${mntpt}/${FREEBSD_BOOTDIR}" "${mntpt}/${BOOTDIR}"

153–154

"${mntpt}/${FREEBSD_BOOTDIR}/loader.efi

168

This is too late. I'd suggest above.

[mhorne]

usr.sbin/bsdinstall/scripts/bootconfig

168

Yep, that is much better. Will update shortly.

[mhorne]

Incorporate imp's suggestions.

[mhorne]

One further simplification, use $FREEBSD_BOOTNAME instead of $FREEBSD_BOOTDIR/loader.efi.