Details
- Reviewers
markj cem emaste arichardson - Commits
- rGaefe30c54371: cat: capsicumize it
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 36235 Build 33124: arc lint + arc unit
Event Timeline
I believe this will break the bootstrap version of cat that is needed for building on Linux/macOS since caph_enter_casper() will fail there.
This probably needs a few more #ifndef BOOTSTRAP_CAT.
If you have a github fork, the github actions will test the non-FreeBSD build automatically for the "main" branch of your repository.
Otherwise this seems fine to me.
Yea, I wasn't sure about Linux/macOs build.
Good to know that! I will verify that!
We don't use the rescue headers to build a BOOTSTRAP version?
The bootstrap version uses tools/build/cross-build/capsicum_stubs.c . I'm not sure what you mean by rescue head?
@arichardson
I just needed to add a new service to the tools/build/Makefile and it work like charm - https://github.com/oshogbo/freebsd-src/runs/1710760934 (mac will finish in a moment).
Do you want me to test something else?
So in the case of the building rescue and the bootstrapping, we are using the libcapsicum/Casper headers that replace the caph_* functions with empty ones.