Build VirtIO modules on all architectures
ClosedPublic
Actions

Authored by jrtc27 on Jan 9 2021, 6:30 AM.

Details

Reviewers

bryanv
imp

Commits

rG32cb85d0f1e8: Build VirtIO modules on all architectures

Summary

Currently only amd64, i386 and powerpc build VirtIO modules, yet all other
architectures have at least one kernel configuration that includes the
transport drivers, and so they lack drivers for all the devices they don't
statically compile into the kernel. Instead, enable the build everywhere so all
architectures have the full set of device drivers available.

Test Plan

No tinderbox regressions

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 36057
Build 32946: arc lint + arc unit

Event Timeline

jrtc27 created this revision.Jan 9 2021, 6:30 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 9 2021, 6:30 AM

jrtc27 requested review of this revision.Jan 9 2021, 6:30 AM

Harbormaster completed remote builds in B36057: Diff 81943.Jan 9 2021, 6:30 AM

Does this survive universe? mips has no virtualization support at all, last I checked... A quick peek at virtio suggests that it's entirely platform neutral...

In D28058#627077, @imp wrote:

Does this survive universe? mips has no virtualization support at all, last I checked... A quick peek at virtio suggests that it's entirely platform neutral...

Yes, tinderbox succeeded (well, except for LINT kernels due to the HID regression). MIPS supports VirtIO just fine, we use it with QEMU's MALTA machine regularly, with FreeBSD's std.MALTA enabling virtio_pci and common devices.

In that case, I'm good!

This revision is now accepted and ready to land.Jan 9 2021, 8:08 PM

It might be useful to also install virtio man pages on all architectures (in share/man/man4/Makefile) then?

bryanv accepted this revision.Jan 19 2021, 5:27 AM

Closed by commit rG32cb85d0f1e8: Build VirtIO modules on all architectures (authored by jrtc27). · Explain WhyJan 21 2021, 1:36 AM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG32cb85d0f1e8: Build VirtIO modules on all architectures.